Skip to content

Update options.mdx #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Update options.mdx #3013

merged 2 commits into from
Oct 30, 2023

Conversation

biuaxia
Copy link
Contributor

@biuaxia biuaxia commented Oct 30, 2023

Change the ZoomFactor and IsZoomControlEnabled in the document to the location of the new version.

Description

The ZoomFactor and IsZoomControlEnabled parameters are out of date and should appear in the document as attributes of Windows!

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Change the ZoomFactor and IsZoomControlEnabled in the document to the location of the new version
@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@biuaxia
Copy link
Contributor Author

biuaxia commented Oct 30, 2023

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

I think this is a document update. Does he also need to synchronize to changlog?

@biuaxia
Copy link
Contributor Author

biuaxia commented Oct 30, 2023

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

The files related to changelog have been submitted.

Update changelog.mdx by biuaxia · Pull Request #3014 · wailsapp/wails

@leaanthony leaanthony merged commit 0533d2e into wailsapp:master Oct 30, 2023
@levinit
Copy link
Contributor

levinit commented Jul 29, 2024

In the latest documentation, these two properties have been changed from Windows only to public options...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants