Skip to content

Special chars bindings unit tests#3485

Merged
leaanthony merged 3 commits intowailsapp:masterfrom
Gjergj:special_chars_bindings
May 17, 2024
Merged

Special chars bindings unit tests#3485
leaanthony merged 3 commits intowailsapp:masterfrom
Gjergj:special_chars_bindings

Conversation

@Gjergj
Copy link
Contributor

@Gjergj Gjergj commented May 16, 2024

Description

Unit tests for #3476

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

# Wails
Version | v2.8.1

# System
┌────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
| OS           | MacOS                                                                                                                       |
| Version      | 14.4.1                                                                                                                      |
| ID           | 23E224                                                                                                                      |
| Go Version   | go1.22.1                                                                                                                    |
| Platform     | darwin                                                                                                                      |
| Architecture | arm64                                                                                                                       |
| CPU          | Apple M1 Pro                                                                                                                |
| GPU          | Chipset Model: Apple M1 Pro Type: GPU Bus: Built-In Total Number of Cores: 14 Vendor: Apple (0x106b) Metal Support: Metal 3 |
| Memory       | 32GB                                                                                                                        |
└────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌───────────────────────────────────────────────────────────────────────┐
| Dependency                | Package Name | Status    | Version        |
| Xcode command line tools  | N/A          | Installed | 2406           |
| Nodejs                    | N/A          | Installed | 21.7.1         |
| npm                       | N/A          | Installed | 10.5.0         |
| *Xcode                    | N/A          | Installed | 15.3 (15E204a) |
| *upx                      | N/A          | Available |                |
| *nsis                     | N/A          | Available |                |
└─────────────────────── * - Optional Dependency ───────────────────────┘

# Diagnosis
Optional package(s) installation details:
  - upx : Available at https://upx.github.io/
  - nsis : More info at https://wails.io/docs/guides/windows-installer/

 SUCCESS  Your system is ready for Wails development!

 ♥   If Wails is useful to you or your company, please consider sponsoring the project:
https://github.com/sponsors/leaanthony

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@Gjergj Gjergj force-pushed the special_chars_bindings branch from 7b8ce39 to ee31111 Compare May 17, 2024 07:39
@Gjergj Gjergj force-pushed the special_chars_bindings branch from ee31111 to 0f6d128 Compare May 17, 2024 07:41
@Gjergj
Copy link
Contributor Author

Gjergj commented May 17, 2024

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

Added

@leaanthony leaanthony enabled auto-merge (squash) May 17, 2024 08:23
@leaanthony leaanthony disabled auto-merge May 17, 2024 08:23
@leaanthony leaanthony merged commit a7a4341 into wailsapp:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants