Fix Drag & Drop JS runtime#3516
Conversation
* implement basic dnd for linux * implemented windows * progress changed linux handling and added coordinates to drop * progress fix drop coordinates on windows * progress remove log from windows * progress move js * update js after merge * fix event listener registration * fix segfault on non file drag * remove logs, fix coordinates * minor changes, simplify to drop only * rename EnableWails -> EnableFileDrop * add documentation (PR id missing) * add PR id to changelog * fix remove casting from malloc * fix nil check for OnFileDrop's callback * fix nil check for OnFileDrop skip event when nil * add error message for nil callback in OnFileDrop --------- Co-authored-by: lyimmi <lelvente.zambo@gmail.com> Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
* implement native drag and drop for macOS * update docs * add to changelog * update docs (macOS is supported) * Fix windows DragAndDrop options * Fix class unset on dragleave for full frame elements * improve class unset (nested elements and borders case)
into feature/1090_native_drag_and_drop_for_file_and_folder
|
Hi @lyimmi , @APshenkin please take a look. |
leaanthony
left a comment
leaanthony
left a comment
There was a problem hiding this comment.
Thanks for taking the time to loop back to this 🙏
What do you think the challenges for this approach might be for a multi-window application?
|
@jakubpeleska @pavelbinar Hope to see this released in v2 soon! |
|
@leaanthony Thanks for taking a look.
As for the multi-window challenges, I can't really speak for the native implementations. However, the runtime JS should work out of the box, assuming that there are separate JS runtimes for each window. That being said, I did not test it, so I can't be sure. @APshenkin and @lyimmi might have more insight into the challenges of native implementations. |
pavelbinar
force-pushed
the
feature/1090_native_drag_and_drop_for_file_and_folder
branch
from
0f84d4a to
600997b
Compare
|
|
||
| // collecting all file paths | ||
| NSString *files_str = @""; | ||
| NSMutableArray *files_strs = [[NSMutableArray alloc] init]; |
There was a problem hiding this comment.
Does this need to be released?
There was a problem hiding this comment.
Here we iterate over NSURL array to convert them to just strings, then join then all in one string.
So files_strs is needed. Only if someone have better know how to do this mapping, as I'm not Objective-C expert 😅.
However files_str is redundant, as it's not used. You can remove it.
There was a problem hiding this comment.
I was thinking the [alloc] would require a [release]
There was a problem hiding this comment.
Oh, yes you are right, sorry misunderstood you 😅
|
Thanks all involved in this monumental effort! Anyone fancy writing a small guide on how to use it? 😅 |
6 participants
Description
This PR completes the drag-and-drop support, which was previously implemented in:
Changes
draganddrop.jswails-drop-target-activedragleaveto avoid flickering of thewails-drop-target-activeclassThis implementation provides developers with enough functionality to start using this feature in production. Therefore, we believe this commit can conclude all previous efforts and mark the drag-and-drop feature as ready for production.
How Has This Been Tested?
Fix was tested on a dummy project available on https://github.com/beam-transfer/wails-drag-and-drop
Video
"--wails-drop-target": "drop""--wails-drop-target": "none"drag-and-drop-demonstration.mp4
Type of change
Checklist:
website/src/pages/changelog.mdxwith details of this PR