Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev extensions, add react to dev tools in electron app #19

Closed
wants to merge 2 commits into from

Conversation

@vujita
Copy link
Collaborator

commented Aug 9, 2019

Includes changes from PR. Which should be merged first before this is reviewed

Add react dev tools to app in development mode

@vujita vujita force-pushed the vujita:dev-extensions branch from b96664d to 1db673c Aug 9, 2019

@@ -0,0 +1 @@
This is a folder for useful extension to be added for developer process

This comment has been minimized.

Copy link
@alanhamlett

alanhamlett Aug 9, 2019

Member

Is this convention? Is it possible to add react dev tools as devDependency instead of checking into repo?

This comment has been minimized.

Copy link
@vujita

vujita Aug 9, 2019

Author Collaborator

I would like to that ideally but it is more path based

I felt it would keep the setup for each person for this simpler, the other way is through env variables

@vujita

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

Closing in favor of react-devtools over a port

@vujita vujita closed this Aug 9, 2019

@vujita vujita deleted the vujita:dev-extensions branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.