Skip to content

Eliminate unecessary logging on restore #43

Merged
merged 1 commit into from Oct 19, 2013

2 participants

@bshi
wal-e member
bshi commented Oct 11, 2013

Resolves #38

Tested on ubuntu 12.04 / boto 2.2

@fdr
wal-e member
fdr commented Oct 19, 2013

Oh wait no I'm just blind. Checking patch...

@fdr
wal-e member
fdr commented Oct 19, 2013

LGTM, squash the two together before commit if you would, please: it'd be easier to read in one shot.

@bshi bshi Eliminate unecessary logging on restore
Tweak race error message by bumping severity to WARNING and note in the
message copy that the URI at one point existed but can no longer be
found.
879124a
@bshi bshi merged commit 473b2b3 into wal-e:master Oct 19, 2013

1 check passed

Details default The Travis CI build passed
@bshi
wal-e member
bshi commented Oct 19, 2013

Squashed. Well balls, github decided also purge the review history :/

@fdr
wal-e member
fdr commented Oct 19, 2013
@bshi bshi deleted the unknown repository branch Oct 19, 2013
@fdr
wal-e member
fdr commented Oct 21, 2013

I recently realized this patch probably makes an extra S3 API request (for pre-checking .exists) when it could be avoided. That kind of sucks for the common case, given the expense of a TLS handshake.

Well, let's leave it in, but it seems like retaining the advantages but getting rid of the ugly stack trace ought to be possible.

@bshi
wal-e member
bshi commented Oct 23, 2013

Hrm, good point. I was under the impression that boto did some rudimentary connection pooling. Keep-alive would at least alleviate the handshake overhead (if not the extra request) no?

@fdr
wal-e member
fdr commented Oct 23, 2013
@bshi
wal-e member
bshi commented Oct 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.