Tested on ubuntu 12.04 / boto 2.2
Oh wait no I'm just blind. Checking patch...
LGTM, squash the two together before commit if you would, please: it'd be easier to read in one shot.
Eliminate unecessary logging on restore
Tweak race error message by bumping severity to WARNING and note in the
message copy that the URI at one point existed but can no longer be
Squashed. Well balls, github decided also purge the review history :/
I recently realized this patch probably makes an extra S3 API request (for pre-checking .exists) when it could be avoided. That kind of sucks for the common case, given the expense of a TLS handshake.
Well, let's leave it in, but it seems like retaining the advantages but getting rid of the ugly stack trace ought to be possible.
Hrm, good point. I was under the impression that boto did some rudimentary connection pooling. Keep-alive would at least alleviate the handshake overhead (if not the extra request) no?