Implement --terse option #44

Merged
merged 1 commit into from Oct 19, 2013

Projects

None yet

5 participants

@fdr
Member
fdr commented Oct 14, 2013

Defined as suppressing logs of level INFO and below.

Altered from original '--quiet' patch with additional hacking from
Daniel Farina daniel@heroku.com.

@Xof Xof Implement --terse option
Defined as suppressing logs of level INFO and below.

Altered from original '--quiet' patch with additional hacking from
Daniel Farina <daniel@heroku.com>.
1ad6d9f
@fdr
Member
fdr commented Oct 14, 2013

@Xof, @bshi, @rotten, @smaftoul, all of you expressed some interest in this. I beefed it up and added some regression testing. Let me know what you think. Other reviewers more than welcome, of course.

The new option is called --terse and suppresses everything below WARNING level.

Original: #27

@rotten
rotten commented Oct 14, 2013

Since I started my new job a few weeks ago I have had neither the time nor
an AWS environment to run PostgreSQL in.

We are working in Rackspace. I've got some crude scripts together to pump
data into Cloud Files (Rackspace's S3 competitor), they are not as nice as
WAL-E though.

I suppose I should look at adding Cloud Files support to WAL-E, but I
haven't had time yet (too busy simply coming up to speed at the new gig).
It is on my long term to-do's to get back to this task. It might not be
until spring/summer though.

@Xof, @bshi, @rotten, @smaftoul, all of you expressed some interest in
this. I beefed it up and added some regression testing. Let me know what
you think. Other reviewers more than welcome, of course.

The new option is called --terse and suppresses everything below WARNING
level.


Reply to this email directly or view it on GitHub:
#44 (comment)

Rick Otten
rotten@windfish.net
O=='=+

@fdr
Member
fdr commented Oct 14, 2013

Hmm. Well, I know that @alex has been pawing at wal-e just a bit probably with an eye to figuring out how to support multiple storage backends. It's a feature I do want, but it's going to take quite a bit of hacking.

That said, I'm open (and intending to) to change WAL-E fairly severely to meet this end. I myself intend to change wal-e's configuration pretty dramatically that may lend some help to this kind of effort.

@alex
Member
alex commented Oct 14, 2013

Yeah I'm also looking at this, I have half an email sent to talk about what approach makes the most sense, but I left the country and got distracted :/ @rotten if you're also interested, I'd love to collaborate

@bshi
Member
bshi commented Oct 14, 2013

lgtm

@Xof
Contributor
Xof commented Oct 15, 2013

+1

@fdr fdr merged commit 1ad6d9f into wal-e:master Oct 19, 2013

1 check passed

Details default The Travis CI build passed
@fdr
Member
fdr commented Oct 19, 2013

Alright, that seems like a long enough period; committed. Tank you to all correspondents.

@fdr fdr deleted the fdr:quiet-redux branch Oct 19, 2013
@fdr fdr referenced this pull request Oct 19, 2013
Closed

--quiet option. #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment