Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: abort if WALE_S3_PREFIX doesn't look like a url #53

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@adamdecaf
Copy link
Contributor

adamdecaf commented Jan 11, 2018

No description provided.

@x4m

This comment has been minimized.

Copy link
Collaborator

x4m commented Jan 12, 2018

Hi! Thanks for the pull request!
Are you sure this is the only protocol acceptable by Go SDK AWS? If so, surely your code is correct. What is the best way to check that?

@adamdecaf

This comment has been minimized.

Copy link
Contributor Author

adamdecaf commented Jan 12, 2018

Are you sure this is the only protocol acceptable by Go SDK AWS?

I'm not sure about that.. It looks like minio cares more about the endpoint url being changed. How about we error if the Scheme || Host are empty strings? Both are required anyway.

https://docs.minio.io/docs/aws-cli-with-minio
https://docs.minio.io/docs/golang-client-quickstart-guide
https://open.microsoft.com/2017/11/09/s3cmd-amazon-s3-compatible-apps-azure-storage/

@x4m

This comment has been minimized.

Copy link
Collaborator

x4m commented Jan 12, 2018

Sounds reasonable.
I've seen installations working with https+s3, but this prefix was not working for WAL-G.

@adamdecaf adamdecaf force-pushed the adamdecaf:abort-unknown-scheme branch from 81062e9 to a9f3bc1 Jan 12, 2018

@adamdecaf

This comment has been minimized.

Copy link
Contributor Author

adamdecaf commented Jan 12, 2018

Updated.

@adamdecaf adamdecaf changed the title upload: abort if WALE_S3_PREFIX doesn't look like an S3 url upload: abort if WALE_S3_PREFIX doesn't look like a url Jan 12, 2018

@x4m x4m merged commit fbe8d21 into wal-g:master Jan 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@x4m

This comment has been minimized.

Copy link
Collaborator

x4m commented Jan 12, 2018

Thanks, pushed.

@adamdecaf adamdecaf deleted the adamdecaf:abort-unknown-scheme branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.