Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notes and hightlight (annotations support) #115

Open
tcitworld opened this issue Nov 12, 2015 · 10 comments
Labels
Milestone

Comments

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Nov 12, 2015

In the far future.

@tcitworld tcitworld added this to the 2.0 milestone Nov 12, 2015
@tcitworld tcitworld added the Feature label Nov 12, 2015
@di72nn di72nn changed the title Show notes and hightlight. Show notes and hightlight (annotations support) Jan 14, 2017
@Strubbl Strubbl modified the milestones: 2.1, 2.0 Jun 28, 2017
@gokceozan

This comment has been minimized.

Copy link

@gokceozan gokceozan commented Aug 2, 2017

Very important feature for me.

@bdunogier

This comment has been minimized.

Copy link

@bdunogier bdunogier commented Nov 4, 2017

Do we have any ideas or experiments on how this could be implemented ?

I have been looking into hypothes.is, and I gotta say that an integration would be really awesome. Given that both the internal annotation system and H do the same thing, their integration into the Android app would share a lot.

@di72nn

This comment has been minimized.

Copy link
Member

@di72nn di72nn commented Nov 5, 2017

I can probably add annotations sync with server, but the UI part is tricky: the app relies on WebView for displaying article content, so annotations need to be added with JavaScript, which I have limited experience with.

@bdunogier

This comment has been minimized.

Copy link

@bdunogier bdunogier commented Jan 9, 2018

@di72nn would you point me to where the javascript black magic is taking place ? I'd like to have a look at it :)

@bdunogier

This comment has been minimized.

Copy link

@bdunogier bdunogier commented Jan 9, 2018

I'm browsing about that a bit. First, there doesn't seem to exist recent libraries focusing on that on github. There are a few that haven't moved for 3, 4 years and seem to have issues on recent android versions.

About Javascript, I have found this exchange, directly related to our issue: https://stackoverflow.com/questions/41670806/how-to-highlight-text-permanently-on-android-webview. The main challenge seems to be the storage of the highlight's coordinates (line, character, whatever). The javascript itself looks pretty straightforward.

@jalcine

This comment has been minimized.

Copy link

@jalcine jalcine commented Feb 12, 2018

@bdunogier It looks like https://developer.mozilla.org/en-US/docs/Web/API/Window/getSelection or https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/getSelection can help here. I can try experimenting with this to see if we can get that kind of information (re: coordination location).

@Gryphus1ne

This comment has been minimized.

Copy link

@Gryphus1ne Gryphus1ne commented Jun 29, 2018

Any word on this? Real note support is the only thing keeping me from being able to really use Wallabag.

@danihodovic

This comment has been minimized.

Copy link

@danihodovic danihodovic commented Dec 25, 2018

This is main blocker from switching from Pocket to Wallabag.

@er314

This comment has been minimized.

Copy link

@er314 er314 commented Sep 22, 2019

Same here,
not a wallabag user as the capability to make annotations is mandatory to me.

@er314

This comment has been minimized.

Copy link

@er314 er314 commented Sep 29, 2019

so annotations need to be added with JavaScript, which I have limited experience with.

I think this feature on android doesn't have to follow the same visual paradigm as the wallabag webapp.
It could follow a simpler route, with :

  • highlight the text selected for annotation (same rendering as text selection already in place, but with a different color)
  • when a hightlighted text is clicked, show a new view (activity), which displays + allows writing/updating the annotation text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.