Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete UI Refresh with Material Design Theming #820

Open
wants to merge 4 commits into
base: master
from

Conversation

@xcffl
Copy link

commented Aug 26, 2019

Fixes #809

Other functionalities are working.
A lot of refactorations have been done. Some are not in the most decent way. Some fixes are required as showed above, but I probably not have that much time recently. Maybe @msfjarvis would like to help?

@msfjarvis

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Maybe @msfjarvis would like to help?

Absolutely. If you rebase this on current master I'd definitely like to take a peek tonight.

@xcffl xcffl force-pushed the xcffl:xcffl/ui-refresh branch 2 times, most recently from 48b4a7e to c0afbac Aug 27, 2019

@tcitworld

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

  • Check why Travis doesn't build anymore
  • Remove the q file added.

@xcffl xcffl force-pushed the xcffl:xcffl/ui-refresh branch from c0afbac to f9e8e36 Aug 27, 2019

xcffl added 2 commits Aug 15, 2019
Refactor UI implentation with the new AndroidX or Material Design lib…
…rary natively

Replace with Material Design Theming templete
Replace with vector icons
Add customized typography

Signed-off-by: xcffl <xcffl@outlook.com>

@xcffl xcffl force-pushed the xcffl:xcffl/ui-refresh branch from f9e8e36 to a5cd230 Aug 27, 2019

@xcffl

This comment has been minimized.

Copy link
Author

commented Aug 27, 2019

I think it's fixed now

@Strubbl

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

There is a conflict in app/build.gradle .
Is it really necessary to increase minSDK from 21 to 24? That would be from Android 5 to 7.

@xcffl

This comment has been minimized.

Copy link
Author

commented Aug 31, 2019

There is a conflict in app/build.gradle .

Will, maybe it needs to be merged sooner before more conflicts arrive. @msfjarvis

Is it really necessary to increase minSDK from 21 to 24? That would be from Android 5 to 7.

Not really. This refresh only requires minSDK to be 19. I didn't aware that there were SDK-aware xml. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.