New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark material theme #1521

Open
nicosomb opened this Issue Dec 1, 2015 · 16 comments

Comments

Projects
None yet
@nicosomb
Member

nicosomb commented Dec 1, 2015

No description provided.

@modos189

This comment has been minimized.

Contributor

modos189 commented Dec 1, 2015

Yes, I had an idea to make a few color variations of the theme.

But is it possible to base the theme stored separately from a few variations of the theme?

This would create a large number of variations of colors, when you upgrade by changing just one code.

@j0k3r

This comment has been minimized.

Member

j0k3r commented Dec 1, 2015

This is an interesting question and it's not doable at the moment.
If you want a new theme to be based on a current one, you'll have to duplicate every thing 😕
Or maybe, re-create all twigs with a single line to require the parent theme.

@tcitworld tcitworld added the Feature label Dec 16, 2015

@nicosomb nicosomb added this to the 2.1.0 milestone Jan 11, 2016

@nicosomb

This comment has been minimized.

Member

nicosomb commented Mar 18, 2016

In fact, it's better (and easier) to create a dark article view.

Have a look to Pocket and others: the UI is still the same, but you can only change the article view.

  • new tab in config: Display

  • a list in this tab to choose the article view background "Dark, Black, Light"

  • a list to choose font size (other issue I'll create)

    What is your opinion about that?

@NumEricR

This comment has been minimized.

Contributor

NumEricR commented Mar 18, 2016

It's ok to developp a different style in artcle view only as a first solution. ie. for first v2 release.

But I think a full dark view should be created (whatever currently displayed page). Otherwise you will get some pages with white background and others with black. A kind of blink display while browsing in wallabag 😟

edit
Whatever Pocket do, remember with "Poche" we had full dark themes: "dark", "dmagenta" and "solarized-dark" 😉

@nicosomb nicosomb modified the milestone: 2.1.0 Apr 12, 2016

@nicosomb nicosomb changed the title from [v2] Dark material theme to Dark material theme Nov 30, 2016

@iav

This comment has been minimized.

iav commented Dec 7, 2016

And nice reading set for sepia:
background: #e9d8ba
text: #5a4129
Font: Droid Sans

@NerosTie

This comment has been minimized.

NerosTie commented Mar 5, 2017

Any news about a dark theme? I'm asking because it's not in a milestone anymore.

@j0k3r j0k3r added the UI label Mar 6, 2017

@gnppn

This comment has been minimized.

gnppn commented Feb 13, 2018

Same question (a year later), a dark web theme would be great.

@STaRDoGG

This comment has been minimized.

STaRDoGG commented Mar 22, 2018

lol, 3 years later and still no dark material theme? Booooooooooo

@j0k3r

This comment has been minimized.

Member

j0k3r commented Mar 22, 2018

@STaRDoGG Do you have free time to work on it? Because we don't at the moment.
So we'll be really happy to review your work on that requested feature.
Otherwise, please don't boo.

@STaRDoGG

This comment has been minimized.

STaRDoGG commented Mar 22, 2018

Unfortunately no. I just installed it for the first time today and attempted to 'quickly' do it by looking through the files, but there's a whooole lotta stuff going on, lol. Lot of frameworks I've never used, etc.; a lot for me to study up on before I follow the flow just to edit a theme. I was just going to dupe the current Material theme and edit a couple of colors in the css.

Something similar to this: https://i.imgur.com/HRqFDpX.png

I just changed a few colors using the Chrome inspector.

@dylan-k

This comment has been minimized.

dylan-k commented Sep 7, 2018

While not a proper theme, I found a useful workaround via the "Dark Night Mode" extension for chrome. I think there are similar extensions for other browsers as well. They can override a theme to make a dark mode happen. It works well enough for me anyway.

@BoyMechanicus

This comment has been minimized.

BoyMechanicus commented Nov 24, 2018

I began work on it yesterday.
Pushed some to github today.
Probably won't be finished tomorrow.

I won't claim to know what I'm doing but I am making progress.

@BoyMechanicus

This comment has been minimized.

BoyMechanicus commented Nov 27, 2018

I have a mostly working dark material theme now. There are some changes I made to a css file I would have preferred to make to a twig file.

@j0k3r

This comment has been minimized.

Member

j0k3r commented Nov 27, 2018

Feel free to open a PR so we can check it!
Could you target the 2.4 branch for that? Because it won't be in 2.3.5 but in 2.4.0. Thanks

@BoyMechanicus

This comment has been minimized.

BoyMechanicus commented Nov 27, 2018

I was actually planning on making it work with the latest stable that came out a two(?) days ago. I'll Make a fork and do a pr. In the meantime have a couple screenshots.
2
1

@BoyMechanicus

This comment has been minimized.

BoyMechanicus commented Nov 27, 2018

Made PR #3791 . Take you time with it. It's 2.3.3 But I'll toy around with 2.4 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment