Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use up-to-date Firefox extension and add F-Droid link for Android app. #3057

Merged
merged 5 commits into from Apr 26, 2017

Conversation

raf64flo
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation yes
Translation yes
License MIT
  • Update URL for Firefox extension to Wallabager instead of deprecated extension
  • Add F-Droid link for Android app
  • Fux a typo

Use up-to-date Firefox extension and add F-Droid link for Android app.
@raf64flo raf64flo changed the title Patch 1 Use up-to-date Firefox extension and add F-Droid link for Android app. Apr 25, 2017
@nicosomb
Copy link
Member

Thank you @raf64flo.

Can you also have a look to docs/fr/user/articles.rst, docs/de/user/articles.rst and docs/it/user/articles.rst please?

@raf64flo
Copy link
Contributor Author

Yep sure.

@raf64flo
Copy link
Contributor Author

@nicosomb Done, even if I'm not sure about the DE and IT translation.

@j0k3r j0k3r requested a review from matteocoder April 25, 2017 13:38
@nicosomb nicosomb requested review from Strubbl and a user April 25, 2017 13:43
@@ -43,7 +43,7 @@ Du kannst das `Chrome-Addon hier <https://chrome.google.com/webstore/detail/wall
Android
"""""""

Du kannst die `Android-App hier <https://play.google.com/store/apps/details?id=fr.gaulupeau.apps.InThePoche> herunterladen`_.
Du kannst die `Android-App hier <https://play.google.com/store/apps/details?id=fr.gaulupeau.apps.InThePoche> herunterladen`_ oder auf `F-Droid <https://f-droid.org/repository/browse/?fdid=fr.gaulupeau.apps.InThePoche>`_.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct translation would be:

Du kannst die `Android-App hier <https://play.google.com/store/apps/details?id=fr.gaulupeau.apps.InThePoche>`_ oder auf `F-Droid <https://f-droid.org/repository/browse/?fdid=fr.gaulupeau.apps.InThePoche>`_ herunterladen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK going to fix it. Thanks!

@j0k3r j0k3r removed the request for review from Strubbl April 25, 2017 14:04
Copy link
Contributor

@matteocoder matteocoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tramite" is more appropriate than "via" in Italian in this context.

@@ -45,7 +45,7 @@ Usando la vostra applicazione per smartphone
Android
"""""""

Potete scaricare `qui l'applicazione per Android <https://play.google.com/store/apps/details?id=fr.gaulupeau.apps.InThePoche>`_.
Potete scaricare `qui l'applicazione per Android <https://play.google.com/store/apps/details?id=fr.gaulupeau.apps.InThePoche>`_ o via `F-Droid <https://f-droid.org/repository/browse/?fdid=fr.gaulupeau.apps.InThePoche>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tramite" is more appropriate than "via" in this context. (sorry for the double comment).

@raf64flo
Copy link
Contributor Author

Thanks @matteocoder is it better?

@matteocoder
Copy link
Contributor

@raf64flo All good!

@j0k3r j0k3r merged commit c5e04b0 into wallabag:2.3 Apr 26, 2017
@j0k3r j0k3r added this to the 2.3.0 milestone Apr 26, 2017
@j0k3r j0k3r mentioned this pull request Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants