New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom driver & schema manager for PostgreSQL 10 #3488

Merged
merged 2 commits into from Dec 13, 2017

Conversation

Projects
None yet
3 participants
@j0k3r
Copy link
Member

j0k3r commented Dec 12, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation wallabag/doc#54
Translation no
CHANGELOG.md no
Fixed tickets #3479
License MIT

Since DBAL guys are waiting for Travis to support PostgreSQL 10 (which seems to be waited for months now) we need to take action to fix migration for our PostgreSQL 10 users.

Introduce a custom driver & schema manager with the fix from the DBAL issue.
User using PostgreSQL 10 will need to add an extra line in the parameters.yml:

     database_driver: pdo_pgsql
+    database_driver_class: Wallabag\CoreBundle\Doctrine\DBAL\Driver\CustomPostgreSQLDriver

j0k3r added some commits Dec 12, 2017

@j0k3r j0k3r added this to the 2.3.1 milestone Dec 12, 2017

@j0k3r j0k3r requested review from nicosomb , Kdecherf and tcitworld Dec 12, 2017

@j0k3r j0k3r merged commit 7026581 into master Dec 13, 2017

5 checks passed

Scrutinizer 1 new issues, 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.

@j0k3r j0k3r deleted the pg-10 branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment