New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial migration when using custom table prefix #3504

Merged
merged 2 commits into from Dec 16, 2017

Conversation

Projects
None yet
3 participants
@aaa2000
Copy link
Contributor

aaa2000 commented Dec 14, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Documentation no
Translation no
CHANGELOG.md no
Fixed tickets #3503, #3486
License MIT

The initial migration doesn't take into account of the database_table_prefix then the next migration fails.

But the postgresql sequence are not prefixed, is it a problem ? How to fix that ?

@j0k3r j0k3r added this to the 2.3.1 milestone Dec 15, 2017

CREATE INDEX IDX_A7AED006A76ED395 ON wallabag_annotation (user_id);
CREATE INDEX IDX_A7AED006BA364942 ON wallabag_annotation (entry_id);
$sql = <<<SQL
CREATE TABLE ${databaseTablePrefix}craue_config_setting (name VARCHAR(255) NOT NULL, value VARCHAR(255) DEFAULT NULL, section VARCHAR(255) DEFAULT NULL, PRIMARY KEY(name));

This comment has been minimized.

@j0k3r

j0k3r Dec 15, 2017

Member

Why don't you use getTable() (defined at the end of that class)?

This comment has been minimized.

@aaa2000

aaa2000 Dec 15, 2017

Contributor

I think because that I believed that could not use method in heredoc (I was wrong) and there are not only table.

@nicosomb

This comment has been minimized.

Copy link
Member

nicosomb commented Dec 16, 2017

@aaa2000 do you need some help here?

@j0k3r

j0k3r approved these changes Dec 16, 2017

@nicosomb
Copy link
Member

nicosomb left a comment

Thank you @aaa2000 and @j0k3r

@j0k3r j0k3r merged commit d1f260e into wallabag:master Dec 16, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment