New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.2 compatibility #3515

Merged
merged 8 commits into from Dec 18, 2017

Conversation

Projects
None yet
2 participants
@j0k3r
Copy link
Member

j0k3r commented Dec 16, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md yes
Fixed tickets #...
License MIT

Just update few things to make Travis build run PHP 7.2 properly. We'll see later to fix issue.

First issue found:

contentthis
is
my
contentthis
is
my
content</p>' contains "this is my content".

/Users/j0k/Sites/github/wallabag/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php:410
@j0k3r

This comment has been minimized.

Copy link
Member

j0k3r commented Dec 18, 2017

Hum that ContentProxyTest issue in test seems to be related to a new version of tidy. 😕

@j0k3r j0k3r requested review from nicosomb , Kdecherf and tcitworld Dec 18, 2017

@j0k3r

This comment has been minimized.

Copy link
Member

j0k3r commented Dec 18, 2017

Nightly build is fixed as well 🎉

j0k3r added some commits Dec 16, 2017

Update dama/doctrine-test-bundle
Because:

PHP Fatal error:  Class 'PHPUnit_Framework_BaseTestListener' not found in /home/travis/build/wallabag/wallabag/vendor/dama/doctrine-test-bundle/src/DAMA/DoctrineTestBundle/PHPUnit/LegacyPHPUnitListener.php on line 7

@j0k3r j0k3r force-pushed the php-7.2 branch from cdd3949 to ad88089 Dec 18, 2017

@nicosomb
Copy link
Member

nicosomb left a comment

🎉 😘

@nicosomb

This comment has been minimized.

Copy link
Member

nicosomb commented Dec 18, 2017

Do we need to merge this PR in 2.4 branch?

@j0k3r

This comment has been minimized.

Copy link
Member

j0k3r commented Dec 18, 2017

I don't think so since I only updated tests. Code was already compatible with PHP 7.2 👍

@nicosomb nicosomb merged commit ef5c8a7 into master Dec 18, 2017

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.

@nicosomb nicosomb deleted the php-7.2 branch Dec 18, 2017

@nicosomb nicosomb added this to the 2.3.1 milestone Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment