New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: copy entry object before sending, to keep id #3516

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
3 participants
@Kdecherf
Copy link
Contributor

Kdecherf commented Dec 17, 2017

Q A
Bug fix? sort of
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md yes
Fixed tickets -
License MIT

Workaround for wallabag/android-app#646

@Kdecherf Kdecherf requested review from j0k3r , nicosomb and tcitworld Dec 17, 2017

api: copy entry object before sending, to keep id
Workaround for wallabag/android-app#646

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>

@Kdecherf Kdecherf force-pushed the delete-id branch from 4ddde2f to f5ea67e Dec 17, 2017

@j0k3r

j0k3r approved these changes Dec 17, 2017

Copy link
Member

j0k3r left a comment

LGTM

@j0k3r j0k3r added this to the 2.3.1 milestone Dec 18, 2017

@nicosomb nicosomb merged commit 3ccf086 into master Dec 18, 2017

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.

@nicosomb nicosomb deleted the delete-id branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment