New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets for subfolder install #3524

Merged
merged 3 commits into from Dec 26, 2017

Conversation

Projects
None yet
5 participants
@Kdecherf
Copy link
Contributor

Kdecherf commented Dec 20, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? -
Documentation no
Translation no
CHANGELOG.md no
Fixed tickets #3485
License MIT

Fixes #3485

Kdecherf added some commits Dec 20, 2017

Update prod assets
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>

@Kdecherf Kdecherf requested review from j0k3r , nicosomb and tcitworld Dec 20, 2017

cs-fixer
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@nicosomb
Copy link
Member

nicosomb left a comment

LGTM but we'll wait for replies on #3485 before merge this PR.

@@ -78,6 +78,12 @@ public function registerContainerConfiguration(LoaderInterface $loader)
'base_url' => 'http://localhost:8080/',
],
]);
} else {

This comment has been minimized.

@nicosomb

@nicosomb nicosomb added this to the 2.3.1 milestone Dec 21, 2017

@JimboJoe
Copy link

JimboJoe left a comment

It's working on my side (YunoHost package).

@j0k3r

j0k3r approved these changes Dec 22, 2017

Copy link
Member

j0k3r left a comment

LGTM

@steiler

This comment has been minimized.

Copy link

steiler commented Dec 24, 2017

Fixes the issue for me. Assets are now properly loaded.
Thanks

@nicosomb nicosomb merged commit 726e2cf into master Dec 26, 2017

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.

@nicosomb nicosomb deleted the fix-assets-sub branch Dec 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment