New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty card title link #3525

Merged
merged 7 commits into from Dec 26, 2017

Conversation

Projects
None yet
3 participants
@Simounet
Copy link
Member

Simounet commented Dec 21, 2017

Hello there,
Long time annoying (me) fix with empty title on not fetched content. The only way (I know) to make it fetched again was to get the previous item and change manually the URL. Now, I using an existing translation to put a default title.
Before:
wallabag-title-before

After:
wallabag-title-after

I couldn't resist sharing the card and tags templates. No differences with that.

馃巹

@j0k3r
Copy link
Member

j0k3r left a comment

LGTM

@j0k3r j0k3r added the UI label Dec 21, 2017

@j0k3r j0k3r added this to the 2.3.1 milestone Dec 21, 2017

<i class="grey-text text-darken-4 activator material-icons right">more_vert</i>
{% endif %}
<a href="{{ path('view', { 'id': entry.id }) }}" title="{{ entry.title| striptags | e('html_attr') }}" class="card-title dot-ellipsis dot-resize-update">
{{ entry.title | striptags | truncate(80, true, '') | raw | default('config.form_rules.faq.variable_description.title'|trans) }}

This comment has been minimized.

@nicosomb

nicosomb Dec 22, 2017

Member

Do we need to create a new translation key or use this one?

This comment has been minimized.

@j0k3r

j0k3r Dec 22, 2017

Member

I think we should create a new translation key 馃憤

This comment has been minimized.

@Simounet

Simounet Dec 22, 2017

Member

Ok, I'll do that with the same translations.

This comment has been minimized.

@Simounet

Simounet Dec 22, 2017

Member

Because there is a lot of files to modify, I would like having a validation before editing everything. I thought about adding this to the entry section, like this:

entry:
    default_title: "xxxxxxxx"

Is it ok for you?

This comment has been minimized.

@j0k3r

j0k3r Dec 22, 2017

Member

It's ok for me

@Simounet

This comment has been minimized.

Copy link
Member

Simounet commented Dec 22, 2017

I created the new key but I encountered some strange translation files (da, fa, ro) with no translation for the previous key I used so I put it as comments.

@nicosomb
Copy link
Member

nicosomb left a comment

Nice. Could you also update the old-but-still-loved baggy theme please?

@nicosomb nicosomb force-pushed the Simounet:fix/empty-card-title-link branch from 090ffae to 5e0c44a Dec 26, 2017

@nicosomb

This comment has been minimized.

Copy link
Member

nicosomb commented Dec 26, 2017

Do we need to update entry.html.twig?

@nicosomb nicosomb merged commit 3473e60 into wallabag:master Dec 26, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment