New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Create new client link with a button #3539

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@nicosomb
Member

nicosomb commented Dec 28, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md no
Fixed tickets #3432
License MIT

Fix #3432

I didn't replace the words, because I don't have an opinion on that.
But @gnppn is right about consistency on buttons/links.

capture d ecran 2017-12-28 a 10 21 06

@nicosomb nicosomb added this to the 2.3.2 milestone Dec 28, 2017

@nicosomb nicosomb requested review from j0k3r, Kdecherf and tcitworld Dec 28, 2017

@Kdecherf

LGTM 👍

@nicosomb nicosomb merged commit 2679eb9 into master Dec 28, 2017

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.

@nicosomb nicosomb deleted the new-client-button branch Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment