New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav actions updated #3541

Merged
merged 6 commits into from Jan 12, 2018

Conversation

Projects
None yet
4 participants
@Simounet
Member

Simounet commented Dec 28, 2017

Hi,
Long time no see. I'm pretty sure you missed my UI PR. 馃惏
I fixed and issue with the new entry and search inputs alignment and I replaced the label icons of these two actions by button so we can submit forms without en return key. It's good for accessibility, mobile or mouse mode. I also simplified the boxes into the nav for better alignment. I gave some love to the nav mobile view, reducing the buttons' margin so we have more space for inputs.
I worked on the JS actions to share the toggle/close methods between new entry and search.

Desktop

Before:
add-entry-before

After:
add-entry-after

Mobile

Before:
add-entry-mobile-before

After:
add-entry-mobile-after

鉀勶笍

@Simounet

This comment has been minimized.

Member

Simounet commented Jan 9, 2018

Hello,
Is the WIP label for me or for reviewers?

@j0k3r

This comment has been minimized.

Member

j0k3r commented Jan 9, 2018

Hum I think it's because you changed html stuff and then some tests are now failing (those which retrieve information from the html to validate the page rendering is ok)

@Simounet

This comment has been minimized.

Member

Simounet commented Jan 9, 2018

Ok, I didn't get that. I'll fix that.

@Simounet

This comment has been minimized.

Member

Simounet commented Jan 9, 2018

I can be wrong but I looked at the failing tests but I don't think that's my fault.

@nicosomb nicosomb force-pushed the Simounet:feature/nav-label-replaced-by-buttons branch from dd158fc to 3f7ec1c Jan 12, 2018

@nicosomb nicosomb force-pushed the Simounet:feature/nav-label-replaced-by-buttons branch from 3f7ec1c to 5614df1 Jan 12, 2018

@nicosomb nicosomb requested review from j0k3r, nicosomb, Kdecherf and tcitworld Jan 12, 2018

@j0k3r

j0k3r approved these changes Jan 12, 2018

@j0k3r j0k3r added this to the 2.3.2 milestone Jan 12, 2018

@nicosomb nicosomb merged commit fd637b9 into wallabag:master Jan 12, 2018

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks
zappr/pr/tasks PR has no open tasks.

@Simounet Simounet deleted the Simounet:feature/nav-label-replaced-by-buttons branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment