Use lang attribute #4257
Merged
Use lang attribute #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can maybe add a new test 😉 |
j0k3r
reviewed
Jan 23, 2020
Simounet
force-pushed
the
feat/lang-attribute
branch
from
92819d1
to
fd64caa
Compare
|
Thanks for not letting me be a lazy boy. :D |
|
You need to run the fixer locally: |
Simounet
force-pushed
the
feat/lang-attribute
branch
from
fd64caa
to
416d44d
Compare
|
Done. |
j0k3r
approved these changes
Jan 24, 2020
nicosomb
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another quick one using the app language for the main html tag and the grabbed site one for our entry content.