Jump to PHP 7.2+ #4441
Merged
Jump to PHP 7.2+ #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating deps - Removing electrolinux/php-html5lib (0.1.0) - Updating doctrine/inflector (1.3.1 => 1.4.3) - Updating doctrine/lexer (1.0.2 => 1.2.1) - Installing symfony/polyfill-php80 (v1.17.0) - Updating symfony/service-contracts (v1.1.8 => v2.1.2) - Installing symfony/deprecation-contracts (v2.1.2) - Updating symfony/mime (v4.4.8 => v5.1.1) - Updating friendsofsymfony/rest-bundle (2.7.4 => 2.8.0) - Updating doctrine/instantiator (1.3.0 => 1.3.1) - Updating ocramius/proxy-manager (2.1.1 => 2.2.3) - Updating php-http/discovery (1.7.4 => 1.8.0) - Updating symfony/http-client-contracts (v1.1.8 => v2.1.2) - Updating symfony/http-client (v4.4.8 => v5.1.1) - Updating php-http/httplug-bundle (1.16.0 => 1.18.0) - Updating symfony/phpunit-bridge (v4.3.11 => v5.1.1) - Updating doctrine/data-fixtures (1.3.3 => 1.4.3) - Updating composer/xdebug-handler (1.4.1 => 1.4.2) - Updating masterminds/html5 (2.7.0 => 2.7.1) - Updating j0k3r/php-readability (1.2.4 => 1.2.5) - Updating phpoption/phpoption (1.7.3 => 1.7.4) - Updating nikic/php-parser (v4.4.0 => v4.5.0) - Installing thecodingmachine/safe (v1.1.1) - Updating spomky-labs/otphp (v9.1.4 => v10.0.1) - Updating pagerfanta/pagerfanta (v2.1.3 => v2.3.0) Package white-october/pagerfanta-bundle is abandoned, you should avoid using it. Use babdev/pagerfanta-bundle instead. - Removing white-october/pagerfanta-bundle (v1.3.2) - Installing babdev/pagerfanta-bundle (v2.4.2) Upgrading PHPStan to 0.12 and use extension installer - Removing phpstan/phpdoc-parser (0.3.5) - Removing nette/utils (v3.1.2) - Removing nette/schema (v1.0.2) - Removing nette/robot-loader (v3.2.3) - Removing nette/php-generator (v3.4.0) - Removing nette/neon (v3.1.2) - Removing nette/finder (v2.5.2) - Removing nette/di (v3.0.4) - Removing nette/bootstrap (v3.0.2) - Updating phpstan/phpstan (0.11.19 => 0.12.29) - Updating phpstan/phpstan-doctrine (0.11.6 => 0.12.16) - Updating phpstan/phpstan-phpunit (0.11.2 => 0.12.11) - Updating phpstan/phpstan-symfony (0.11.6 => 0.12.6) - Installing phpstan/extension-installer (1.0.4) Upgrading jms/serializer-bundle to version 3 (and willdurand/hateoas-bundle to version 2) - Removing phpoption/phpoption (1.7.4) - Removing phpcollection/phpcollection (0.5.0) - Removing jms/parser-lib (1.0.0) - Updating jms/metadata (1.7.0 => 2.3.0) - Updating jms/serializer (1.14.1 => 3.7.0) - Updating jms/serializer-bundle (2.4.4 => 3.6.0) - Updating willdurand/hateoas (2.12.0 => 3.6.0) - Updating willdurand/hateoas-bundle (1.4.0 => 2.1.0) Upgrading dama/doctrine-test-bundle to version 6 - Updating dama/doctrine-test-bundle (v5.0.3 => v6.2.0)
j0k3r
force-pushed
the
feature/drop-php-7.1
branch
from
2c42a1f
to
732ec8a
Compare
tcitworld
approved these changes
Jun 15, 2020
Kdecherf
approved these changes
Jun 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already jumped to PHP 7.1+ almost 1 year and half ago in the horizon to release the 2.4.0 version (and at that time the 7.1 still has active support).
Sadly, the 2.4.0 is still not released.
We are still working on it but have less time than before.
In the mean time, I think it's best to jump to PHP 7.2+ to avoid having to wait for the next minor version of wallabag (2.5.0).
Support for 7.2 will end in November 2020.
Which means, we should jump to 7.3 right away but I think it's too fast for most people. Also Symfony still required PHP >=7.2.5 for the current master (the upcoming 5.2.0).
I think it's safe to jump to 7.2+.
It'll eventually allow us to upgrade the Symfony version (to 4.x or 5.x) without forcing (again) people to upgrade their PHP version.
What you guys think about that?
Deps summary of the update
Updating deps
Package white-october/pagerfanta-bundle is abandoned, you should avoid using it. Use babdev/pagerfanta-bundle instead.
Upgrading PHPStan to 0.12 and use extension installer
Upgrading jms/serializer-bundle to version 3 (and willdurand/hateoas-bundle to version 2)
Upgrading dama/doctrine-test-bundle to version 6