Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to sort the feed entries by updated_at #5659

Merged
merged 1 commit into from Mar 15, 2022

Conversation

agallou
Copy link
Contributor

@agallou agallou commented Mar 10, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation yes/no
Translation no
CHANGELOG.md yes/no
License MIT

There is now an option to sort the feed entires by updated_at, on the
controler : a sort querystring argument that accepts either "created"
or "updated".

Fixs #5658

@j0k3r j0k3r changed the title this change adds an option to sort the feed entires by updated_at Add an option to sort the feed entires by updated_at Mar 10, 2022
@j0k3r j0k3r changed the title Add an option to sort the feed entires by updated_at Add an option to sort the feed entries by updated_at Mar 10, 2022
@j0k3r
Copy link
Member

j0k3r commented Mar 10, 2022

Could you run php bin/php-cs-fixer fix to fix CS issues? Thanks

@j0k3r j0k3r added this to the 2.5.0 milestone Mar 10, 2022
@nicosomb
Copy link
Member

@agallou thank you. Do you plan to write some tests?

@agallou
Copy link
Contributor Author

agallou commented Mar 12, 2022

Thank you for your feedbacks.
@j0k3r i'ved fixed fixed the linter errors and applied your suggestions
@nicosomb i've add some tests on the new parameter

@agallou
Copy link
Contributor Author

agallou commented Mar 14, 2022

@j0k3r i've change the HTTP status code, and simplified the tests by using the crawler

@j0k3r
Copy link
Member

j0k3r commented Mar 14, 2022

Good job! Thanks for your explanation.
You can squash your commits and we'll be good to go!

@agallou
Copy link
Contributor Author

agallou commented Mar 14, 2022

ok, I've juste rebased the commits.

Kdecherf
Kdecherf previously approved these changes Mar 14, 2022
src/Wallabag/CoreBundle/Entity/Entry.php Outdated Show resolved Hide resolved
There is now an option to sort the feed entires by updated_at, on the
controler : a sort querystring argument that accepts either "created"
or "updated".
Copy link
Member

@Kdecherf Kdecherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@j0k3r j0k3r merged commit 33a7b1e into wallabag:master Mar 15, 2022
@j0k3r
Copy link
Member

j0k3r commented Mar 15, 2022

Thanks @agallou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants