Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted diff, or a mode like comm #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexandre-mbm
Copy link

@alexandre-mbm alexandre-mbm changed the title New YAML format and inverted diff (comm) Inverted diff, or a mode like comm Sep 19, 2014
@wallace
Copy link
Owner

wallace commented Sep 29, 2014

Hi @alexandre-mbm , thank you for your contributions. I like the idea here as well as your suggestion in #6.

I wonder if we shouldn't combine the functionality in your PR into the compare_hashes instead of having two methods. I'm not certain about combining Yamlcomm but I think I like the idea.

Also, at the very least, if the combining the functionality of commonality and error messages doesn't work, I'd prefer to have test coverage of the new functionality as well as moving the Yamlcomm class into its own file.

Are you interested in working with my suggestions? If not, I'm happy to take over and move this forward but I'm not sure when I'll get to address it.

@alexandre-mbm
Copy link
Author

I am going in trip now and I don't have time to analize your suggestions into 15 days.

@wallace
Copy link
Owner

wallace commented Sep 29, 2014

Okay, sounds good. I should have some time in the next 15 days. Have fun on your trip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants