Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing trait change #49

Merged
merged 8 commits into from
Apr 26, 2023
Merged

Testing trait change #49

merged 8 commits into from
Apr 26, 2023

Conversation

devinpearson
Copy link
Contributor

This is an experimental change to remove downcasting and reduce the complexity of the traits applied to the coin wallets and the blockchain connectors.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (9bbea8e) 29.59% compared to head (d257048) 29.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   29.59%   29.55%   -0.05%     
==========================================
  Files          46       46              
  Lines        5470     5340     -130     
==========================================
- Hits         1619     1578      -41     
+ Misses       3851     3762      -89     
Impacted Files Coverage Δ
coins/bitcoin/src/bitcoin_address.rs 30.50% <ø> (+1.47%) ⬆️
coins/bitcoin/src/bitcoin_amount.rs 73.78% <ø> (+4.06%) ⬆️
coins/bitcoin/src/bitcoin_wallet.rs 8.46% <0.00%> (-0.28%) ⬇️
.../src/bitcoin_wallet/test_bitcoin_wallet_builder.rs 100.00% <ø> (ø)
coins/bitcoin/src/blockstream.rs 50.74% <ø> (+1.29%) ⬆️
coins/core/src/blockchain_connector.rs 0.00% <0.00%> (ø)
coins/core/src/crypto_amount.rs 0.00% <ø> (ø)
coins/ethereum/src/ethclient.rs 0.00% <ø> (ø)
coins/ethereum/src/ethereum_amount.rs 0.00% <ø> (ø)
coins/ethereum/src/ethereum_wallet.rs 50.32% <ø> (+1.01%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@amilumibe amilumibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, we can build off of this and check how from the implementation side things could be streamlined

@devinpearson devinpearson marked this pull request as ready for review April 26, 2023 06:25
@devinpearson devinpearson merged commit 7284505 into main Apr 26, 2023
@devinpearson devinpearson deleted the testing-trait-change branch April 26, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants