-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing trait change #49
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 29.59% 29.55% -0.05%
==========================================
Files 46 46
Lines 5470 5340 -130
==========================================
- Hits 1619 1578 -41
+ Misses 3851 3762 -89
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good, we can build off of this and check how from the implementation side things could be streamlined
This is an experimental change to remove downcasting and reduce the complexity of the traits applied to the coin wallets and the blockchain connectors.