New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Only ERC67 supported currently" error when scanning address #12

Closed
davalb opened this Issue May 11, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@davalb
Member

davalb commented May 11, 2017

When I use the camera-icon in the lower right corner of the main screen to scan an address I get this error: "Only ERC67 supported currently". However when I open the "Transfer"-screen and use the camera-icon there (next to the To-Address-field), I dont get this error (using the same address). I would have expected that this error appears either using both icons or not at all.

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi May 11, 2017

Member

Thanks for the feedback! I think we should push ERC67 and try to not use context-free plain addresses - but you are right from a user perspective this is not good and I will fix it.

ref: ethereum/EIPs#67

Member

ligi commented May 11, 2017

Thanks for the feedback! I think we should push ERC67 and try to not use context-free plain addresses - but you are right from a user perspective this is not good and I will fix it.

ref: ethereum/EIPs#67

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi May 11, 2017

Member

Bit more background to the error:

  • the transfer activity gives the context that this 0x thing is an address
  • in the main-activity you do not really know what this is (hence ERC67 needed) - also you have multiple ways to react - you could want to transfer some value to the address or you could want to import it to the address book
Member

ligi commented May 11, 2017

Bit more background to the error:

  • the transfer activity gives the context that this 0x thing is an address
  • in the main-activity you do not really know what this is (hence ERC67 needed) - also you have multiple ways to react - you could want to transfer some value to the address or you could want to import it to the address book

ligi added a commit that referenced this issue May 28, 2017

Interpret more scanned content
+addresses (with actions "import addressbook" and "trasfer")
+JSON Key
+ECDSA key

closes #12
@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi May 31, 2017

Member

Yes this is exactly what c6ce7e3 is doing - now you can scan:

  • private key (e.g. from MEW)
  • JSON key (e.g. from walleth on other phone)
  • address ( then you get asked for add to addressbook or transaction

Will release a version with this change soon. Thanks for the feedback!

Member

ligi commented May 31, 2017

Yes this is exactly what c6ce7e3 is doing - now you can scan:

  • private key (e.g. from MEW)
  • JSON key (e.g. from walleth on other phone)
  • address ( then you get asked for add to addressbook or transaction

Will release a version with this change soon. Thanks for the feedback!

@ligi ligi closed this in 4edb485 Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment