New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline transaction test failed #56

Closed
soldier9945 opened this Issue Sep 26, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@soldier9945

soldier9945 commented Sep 26, 2017

Hi!

I have tried to test the offline transaction function you implemented in Walleth, but I couldn't get the QR code with the transaction data.

What I have done:

  • Created an "Online Wallet" on my main smartphone
  • Got 3 ETH from the Faucet to that "Online Wallet"
  • Copied the APK to an offline, freshly reset android phone, no Wifi connected, no SIM
  • Opened Walleth, renamed the automatically created account to "Offline Wallet"
  • On my main phone, I added a new account by scanning the public address from the "Offline Wallet"
  • Sent 1 ETH from the "Online Wallet" to the "Offline Wallet"
  • From the main smartphone I selected my "Offline Wallet" without private key (watch-only?)
  • I set up a transfer of all the funds on that "Offline Wallet" to the "Online Wallet"
  • Tried to validate the transaction thinking there would be a QR Code shown, but there wasn't

After some trial and nothing, I'm lost and I don't know where the QR Code of the transaction is supposed to show up?

Can you help me? Thanks!

@ligi ligi added the bug 🐛 label Sep 26, 2017

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Sep 26, 2017

Member

Thanks for the detailed report - I could reproduce it and I will write a fix and a test for this.

Member

ligi commented Sep 26, 2017

Thanks for the detailed report - I could reproduce it and I will write a fix and a test for this.

@soldier9945

This comment has been minimized.

Show comment
Hide comment
@soldier9945

soldier9945 Oct 10, 2017

Any news on this issue? I'd be glad to help testing a fixed version.

soldier9945 commented Oct 10, 2017

Any news on this issue? I'd be glad to help testing a fixed version.

ligi added a commit that referenced this issue Oct 28, 2017

ligi added a commit that referenced this issue Oct 28, 2017

ligi added a commit that referenced this issue Oct 28, 2017

@soldier9945

This comment has been minimized.

Show comment
Hide comment
@soldier9945

soldier9945 Oct 28, 2017

Hi, I've just retested the offline signing of a transaction using the main net (a very small amount) on Walleth 0.21 with both devices.

It seems to work now on the online device, I can create and see the unsigned transaction and QR code when I select the entry.

Now on the offline device I can't seem to find an option to read the unsigned transaction QR code, sign it and show the signed transaction as a new QR code.

Did I misunderstand the way offline signing is intended in this app or is there still some code missing to do what I tried?

What I have done:

From the online phone:

  1. Added my wallet address on my main smartphone (online) without private key
  2. I set up a transaction for a small amount of ETH to another of my wallet addresses.
  3. Now I can see the unsigned transaction on the right column (send TXs) and I can select it showing the transaction details and the QR code of the unsigned transaction (great! 😄)

From the offline phone:

  1. Copied the APK to an offline, freshly reset android phone, no Wifi connected, no SIM
  2. Imported my unencrypted private key from my printed paper wallet (the key corresponding to the address configured as watch only on the online device)
  3. Tried to sign the unsigned transaction by:
  • No green arrow showing to create a transaction (phone is offline so balance is 0, that's why)
  • Using the bottom right camera icon to scan the transaction QR code
    -- choosing "Perform transaction" after scanning
    -- app interprets it as a destination address but scanned address is wrong because it's not the same as the TX address shown on the online phone
    -- app shows the form to create a new transaction
  • Using the Offline Transaction option from the menu (top left), doesn't seem to be the way to go because it says "Relay Transaction" which seems to imply this is to be used on the online phone to broadcast an already signed transaction
    -- Tried nonetheless, app seems to read the QR code but the TX address is not the same as the one shown on the online phone

Thanks for your help / clarification on the matter

PS: I see you were working on this issue a few hours ago, maybe I'm posting too soon. Eager to test this! 😋 because the "competition" doesn't seem to offline sign using a smartphone, WHY??? 😨 https://airgap.it/ for example)

soldier9945 commented Oct 28, 2017

Hi, I've just retested the offline signing of a transaction using the main net (a very small amount) on Walleth 0.21 with both devices.

It seems to work now on the online device, I can create and see the unsigned transaction and QR code when I select the entry.

Now on the offline device I can't seem to find an option to read the unsigned transaction QR code, sign it and show the signed transaction as a new QR code.

Did I misunderstand the way offline signing is intended in this app or is there still some code missing to do what I tried?

What I have done:

From the online phone:

  1. Added my wallet address on my main smartphone (online) without private key
  2. I set up a transaction for a small amount of ETH to another of my wallet addresses.
  3. Now I can see the unsigned transaction on the right column (send TXs) and I can select it showing the transaction details and the QR code of the unsigned transaction (great! 😄)

From the offline phone:

  1. Copied the APK to an offline, freshly reset android phone, no Wifi connected, no SIM
  2. Imported my unencrypted private key from my printed paper wallet (the key corresponding to the address configured as watch only on the online device)
  3. Tried to sign the unsigned transaction by:
  • No green arrow showing to create a transaction (phone is offline so balance is 0, that's why)
  • Using the bottom right camera icon to scan the transaction QR code
    -- choosing "Perform transaction" after scanning
    -- app interprets it as a destination address but scanned address is wrong because it's not the same as the TX address shown on the online phone
    -- app shows the form to create a new transaction
  • Using the Offline Transaction option from the menu (top left), doesn't seem to be the way to go because it says "Relay Transaction" which seems to imply this is to be used on the online phone to broadcast an already signed transaction
    -- Tried nonetheless, app seems to read the QR code but the TX address is not the same as the one shown on the online phone

Thanks for your help / clarification on the matter

PS: I see you were working on this issue a few hours ago, maybe I'm posting too soon. Eager to test this! 😋 because the "competition" doesn't seem to offline sign using a smartphone, WHY??? 😨 https://airgap.it/ for example)

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Oct 28, 2017

Member

Thanks again for your input and sorry for the delay with the fix - had some other stuff todo in preparation for DevCon3. I found the issue - slipped in with network-switching and geth update - and will try to fix it ASAP and would be really happy if you could retest.
What the referenced commit is doing: fixes a flow when you want to relay a signed tx coming from MEW - also in the area of offline transactions - but does not yet fix your flow (yet)
PS: you are doing everything right - the problem is on the app side
PPS: please give me your ETH address - want to send you some WALL tokens as I found your input valuable

Member

ligi commented Oct 28, 2017

Thanks again for your input and sorry for the delay with the fix - had some other stuff todo in preparation for DevCon3. I found the issue - slipped in with network-switching and geth update - and will try to fix it ASAP and would be really happy if you could retest.
What the referenced commit is doing: fixes a flow when you want to relay a signed tx coming from MEW - also in the area of offline transactions - but does not yet fix your flow (yet)
PS: you are doing everything right - the problem is on the app side
PPS: please give me your ETH address - want to send you some WALL tokens as I found your input valuable

@soldier9945

This comment has been minimized.

Show comment
Hide comment
@soldier9945

soldier9945 Oct 28, 2017

No problem, I'm glad for your project to exist because I would have to learn programming for Android prior to getting to what I want 😉. And as stated previously, I'm here to help.

Edit: ETH Address: 0xBD6206599b9E69E97F8dDa0e05Da86337cd383Cc
Thanks alot! Looking for that WALL token you're talking about... (I have no idea what those are atm)
Edit2: MyEtherWallet/ethereum-lists@26f7b6e found it... it's only on the rinkeby network, right?

soldier9945 commented Oct 28, 2017

No problem, I'm glad for your project to exist because I would have to learn programming for Android prior to getting to what I want 😉. And as stated previously, I'm here to help.

Edit: ETH Address: 0xBD6206599b9E69E97F8dDa0e05Da86337cd383Cc
Thanks alot! Looking for that WALL token you're talking about... (I have no idea what those are atm)
Edit2: MyEtherWallet/ethereum-lists@26f7b6e found it... it's only on the rinkeby network, right?

ligi added a commit that referenced this issue Oct 29, 2017

ligi added a commit that referenced this issue Oct 29, 2017

@ligi ligi closed this in 492a895 Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment