Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting errors when relaying transactions fail #345

Merged
merged 1 commit into from Mar 22, 2019

Conversation

@omarbenhamid
Copy link

omarbenhamid commented Mar 22, 2019

As followup of issue : #343
Change 1 : In RelayTransctionWorker : Added a the error to transctionState.errorLog + added the missing upsert to save the modification of the transaction.
Change 2 : The upsert of change 1 will make LiveData propsoe the transaction again for relaying : I optimized the @query in DAO to query only transactions that need to be relayed and modified DataProvidingService accordingly.

@ligi
ligi approved these changes Mar 22, 2019
@ligi

This comment has been minimized.

Copy link
Member

ligi commented Mar 22, 2019

👍

@ligi ligi merged commit f7df17f into walleth:master Mar 22, 2019
5 checks passed
5 checks passed
kontinuum/assemble result
Details
kontinuum/checkout checkout done
Details
kontinuum/lint result
Details
kontinuum/test result
Details
kontinuum/testNoGethNoFirebaseForFDroidOfflineDebugComposer result
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.