Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return TXHASH to the calling Activity when a transaction is created by Intent #347

Merged
merged 2 commits into from Mar 25, 2019

Conversation

@omarbenhamid
Copy link

omarbenhamid commented Mar 25, 2019

This contributes to #149

Currently starting a VIEW Intent on ERC681 URL opens WallETH to create the transaction, but calling native DApp needed the transaction hash to be able to verify and track the transaction.

This was not always returned back by IntentHandlerActivity. Now it is fixed.

@ligi
ligi approved these changes Mar 25, 2019
@ligi

This comment has been minimized.

Copy link
Member

ligi commented Mar 25, 2019

Thanks for your valuable contributions!

@ligi ligi merged commit b8f8a89 into walleth:master Mar 25, 2019
5 checks passed
5 checks passed
kontinuum/assemble result
Details
kontinuum/checkout checkout done
Details
kontinuum/lint result
Details
kontinuum/test result
Details
kontinuum/testNoGethNoFirebaseForFDroidOfflineDebugComposer result
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.