New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '.' in etherscan URL in case of mainnet. #73

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@chriseth
Contributor

chriseth commented Oct 24, 2017

The mainnet uses an empty prefix for etherscan, which would result
in a URL of "https://.etherscan.io" if not handled specially.

--

This is my first ever piece of kotlin code. I have no idea whether it works - I could not find any build instructions.

Remove '.' in etherscan URL in case of mainnet.
The mainnet uses an empty prefix for etherscan, which would result
in a URL of "https://.etherscan.io" if not handled specially.

@ligi ligi merged commit 56308e9 into walleth:master Oct 24, 2017

4 of 5 checks passed

kontinuum/assemble spoon in progress
Details
kontinuum/checkout checkout done
Details
kontinuum/lint result
Details
kontinuum/spoon result
Details
kontinuum/test result
Details
@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Oct 24, 2017

Member

Thanks so much - should do more on the main-net - currently mainly on test-nets ;-)
Can you please give me your eth-address so I can add you to the contributor list?

Member

ligi commented Oct 24, 2017

Thanks so much - should do more on the main-net - currently mainly on test-nets ;-)
Can you please give me your eth-address so I can add you to the contributor list?

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Oct 24, 2017

Member

just saw etherscan also accepts these malformed URLs and you do not really notice the change - but still better to remove it!

Member

ligi commented Oct 24, 2017

just saw etherscan also accepts these malformed URLs and you do not really notice the change - but still better to remove it!

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Oct 24, 2017

Contributor

Really? I tried and it did not work for me: Firefox can’t find the server at .etherscan.io.

Contributor

chriseth commented Oct 24, 2017

Really? I tried and it did not work for me: Firefox can’t find the server at .etherscan.io.

@chriseth chriseth deleted the chriseth:fix_etherscan_mainnet_url branch Oct 24, 2017

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Oct 24, 2017

Member

Yes - seems to be a browser thig - just tried 4 browsers:

  • Brave
  • Chrome
  • Samsung
  • Firefox

and only Firefox rejected the URL - the other ones remove the dot

Member

ligi commented Oct 24, 2017

Yes - seems to be a browser thig - just tried 4 browsers:

  • Brave
  • Chrome
  • Samsung
  • Firefox

and only Firefox rejected the URL - the other ones remove the dot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment