Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Demo code to set block devices in state #16
Conversation
axw
reviewed
Jan 29, 2015
| @@ -327,3 +327,20 @@ func (m *Machine) SetSupportedContainers(containerTypes ...instance.ContainerTyp | ||
| func (m *Machine) SupportsNoContainers() error { | ||
| return m.SetSupportedContainers([]instance.ContainerType{}...) | ||
| } | ||
| + | ||
| +// DEMO ONLY - NOT PRODUCTION | ||
| +// This duplicates api on diskmanager. Need to consolidate. |
axw
reviewed
Jan 29, 2015
| + result.Results[i].Error = common.ServerError(common.ErrPerm) | ||
| + continue | ||
| + } | ||
| + err = m.SetMachineBlockDevices(stateBlockDeviceInfo(arg.BlockDevices)...) |
axw
Jan 29, 2015
Collaborator
This should be using state.setProvisionedBlockDeviceInfo, not SetMachineBlockDevices.
|
Please use setProvisionedBlockDeviceInfo instead. With that, LGTM. |
added a commit
that referenced
this pull request
Jan 29, 2015
wallyworld
merged commit 708c954
into
storage-feature
Jan 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedJan 29, 2015
After creating the block devices on a machine, record the info in state.