Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Test fixes and default storage size #20
Conversation
axw
reviewed
Jan 29, 2015
| + Pool: "pool", | ||
| + Count: 1, | ||
| + }) | ||
| + s.testParse(c, "", storage.Constraints{ |
axw
Jan 29, 2015
Collaborator
if there are no fields at all, that should probably be an error instead
axw
reviewed
Jan 29, 2015
| + s.testParse(c, "", storage.Constraints{ | ||
| + Count: 1, | ||
| + }) | ||
| + s.testParse(c, ",", storage.Constraints{ |
axw
reviewed
Jan 29, 2015
| @@ -21,7 +21,7 @@ const ( | ||
| RootfsStorageDir = "storage-dir" | ||
| ) | ||
| -// rootfsProviders create volume sources which use loop devices. | ||
| +// rootfsProviders create volume sources which mount filesystems. |
axw
Jan 29, 2015
Collaborator
that whole comment is whacko. how about
// rootfsProvider implements a storage.Provider, providing "filesystems"
// backed by directories on the root filesystem.
|
LGTM |
added a commit
that referenced
this pull request
Jan 29, 2015
wallyworld
merged commit fa36006
into
storage-feature
Jan 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedJan 29, 2015
Fix some tests.
Make default storage constraint size = 1G
Make default storage count = 1 regardless of size.