Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
uniter/upgrade: Added steps for setting installed #31
Conversation
wallyworld
reviewed
Aug 20, 2015
| +func addInstalled(opsFile string, state *operation.State) error { | ||
| + statefile := operation.NewStateFile(opsFile) | ||
| + if state.Kind == operation.Install || state.Kind == operation.RunHook && state.Hook.Kind == hooks.Install { | ||
| + state.Installed = false |
wallyworld
Aug 20, 2015
Owner
do we really need this line?
why not just write out the file if Installed is false and it should be true?
wallyworld
reviewed
Aug 20, 2015
| + "github.com/juju/juju/worker/uniter/operation" | ||
| +) | ||
| + | ||
| +func (s *upgradeStateContextSuite) TestInstalledBooleanFalseIfInstalling(c *gc.C) { |
mattyw
changed the title from
WIP: uniter/upgrade: Added steps for setting installed
to
uniter/upgrade: Added steps for setting installed
Aug 20, 2015
added a commit
that referenced
this pull request
Aug 20, 2015
wallyworld
merged commit 6c6cf22
into
wallyworld:uniter-solver
Aug 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mattyw commentedAug 20, 2015
No description provided.