Initial storage pools #8

Merged
merged 4 commits into from Jan 27, 2015

Conversation

Projects
None yet
2 participants
Owner

wallyworld commented Jan 27, 2015

Add a 1.23 upgrade step to create storage pools ootb for the ebs provider.

When provisioning an ec2 instance, copy the options from the pool used for the deployment to the block device mapping params.

Note: I wanted to copy availability zone to block device params but it appears this isn't supported by goamz yet. Neither is encryption param.

provider/ec2/storage/ebs.go
+ Encrypted = "encrypted"
+
+ // The Availability Zone in which to create the volume.
+ AvailabilityZone = "availability-zone"
@axw

axw Jan 27, 2015

Collaborator

d

storage/interface.go
+ // supplied options from a user friendly value to the equivalent
+ // provider specific value.
+ // eg for EBS providers, "magnetic" will be translated to "standard".
+ TranslateUserOptions(map[string]interface{}) map[string]interface{}
@axw

axw Jan 27, 2015

Collaborator

The provider should handle this internally, when given a map. It doesn't need to be surfaced like this.

Collaborator

axw commented Jan 27, 2015

LGTM, can be cleaned up post-demo.

wallyworld added a commit that referenced this pull request Jan 27, 2015

@wallyworld wallyworld merged commit 4c8edc6 into storage-feature Jan 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment