Add support for default pools for env providers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conf, err := st.EnvironConfig() | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| conf, err := st.EnvironConfig() |
There was a problem hiding this comment.
This looks fine for now, though I think we should rework this later so that state is not calling into the storage package. It would be better if we made these sorts of decisions in the API server code. Validation is tricky, and probably means extending the policy code.
There was a problem hiding this comment.
Agreed. Rework definitely needed. I felt dirty for sure, but it was expedient.
|
Possible simplification re cons.Pool != "" check, but otherwise LGTM. |
wallyworld
added a commit
that referenced
this pull request
Jan 27, 2015
Add support for default pools for env providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now a registry of default pools for environment types.
If storage is specified without a pool, the default is used.