Add defaultOptions spec option

walmartlabs · Dec 26, 2012 · 92b7e4d · 92b7e4d
1 parent 7a1dd6f
commit 92b7e4d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/src/collection.js b/src/collection.js
@@ -45,6 +45,12 @@ dataObject('collection', {
   bind: 'bindCollection',
   unbind: 'unbindCollection',
   options: '_setCollectionOptions',
+  defaultOptions: {
+    render: true,
+    fetch: true,
+    success: false,
+    errors: true
+  },
   change: '_onCollectionReset',
   $el: 'getCollectionElement',
   cidAttrName: collectionCidAttributeName

diff --git a/src/data-object.js b/src/data-object.js
@@ -67,14 +67,9 @@ function dataObject(type, spec) {
 
   function objectOptions(dataObject, options) {
     if (!this._objectOptionsByCid[dataObject.cid]) {
-      this._objectOptionsByCid[dataObject.cid] = {
-        render: true,
-        fetch: true,
-        success: false,
-        errors: true
-      };
+      this._objectOptionsByCid[dataObject.cid] = {};
     }
-    _.extend(this._objectOptionsByCid[dataObject.cid], options || {});
+    _.extend(this._objectOptionsByCid[dataObject.cid], spec.defaultOptions, options);
     return this._objectOptionsByCid[dataObject.cid];
   }
 

diff --git a/src/model.js b/src/model.js
@@ -30,6 +30,12 @@ dataObject('model', {
   bind: 'bindModel',
   unbind: 'unbindModel',
   options: '_setModelOptions',
+  defaultOptions: {
+    render: true,
+    fetch: true,
+    success: false,
+    errors: true
+  },
   change: '_onModelChange',
   $el: '$el',
   cidAttrName: modelCidAttributeName