Fixing bug #1179516 - Clicking on chart item don't filter other KPIs …

…properly
walteram · Jan 9, 2015 · fc6d294 · fc6d294
1 parent 75bb52e
commit fc6d294
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/...hboard-ui-nvd3/src/main/java/org/jboss/dashboard/ui/components/chart/NVD3ChartViewer.java b/...hboard-ui-nvd3/src/main/java/org/jboss/dashboard/ui/components/chart/NVD3ChartViewer.java
@@ -14,11 +14,12 @@
  * limitations under the License.
  */
 package org.jboss.dashboard.ui.components.chart;
-
+import java.util.*;
 import org.jboss.dashboard.ui.Dashboard;
 import org.jboss.dashboard.dataset.DataSet;
 import org.jboss.dashboard.displayer.chart.AbstractChartDisplayer;
 import org.jboss.dashboard.domain.Interval;
+import org.jboss.dashboard.domain.label.LabelInterval;
 import org.jboss.dashboard.ui.components.DataDisplayerViewer;
 import org.jboss.dashboard.ui.components.DashboardHandler;
 import org.jboss.dashboard.provider.DataProperty;
@@ -36,12 +37,11 @@ public abstract class NVD3ChartViewer extends DataDisplayerViewer {
 
     public CommandResponse actionApplyLink(CommandRequest request) throws Exception {
         AbstractChartDisplayer abstractChartDisplayer = (AbstractChartDisplayer) getDataDisplayer();
-        DataProperty property = abstractChartDisplayer.getDomainProperty();
-        Integer series = Integer.decode(request.getRequestObject().getParameter(PARAM_NSERIE));
-        DataSet dataSet = abstractChartDisplayer.buildXYDataSet();
-        Interval interval = (Interval) dataSet.getValueAt(series, 0);
+        DataProperty property = abstractChartDisplayer.getDomainProperty();		
+        ArrayList<String> list = new ArrayList<String>();
+        list.add(request.getRequestObject().getParameter(PARAM_NSERIE));		        
         Dashboard dashboard = DashboardHandler.lookup().getCurrentDashboard();
-        if (dashboard.filter(property.getPropertyId(), interval, FilterByCriteria.ALLOW_ANY)) {
+        if (dashboard.filter(property.getPropertyId(), null, true, null, true, list, FilterByCriteria.ALLOW_ANY)) {
             return new ShowCurrentScreenResponse();
         }
         return null;

diff --git a/...dashboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_barchart_script.jsp b/...dashboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_barchart_script.jsp
@@ -76,7 +76,7 @@
        <% if( enableDrillDown ) {%>
           graph.discretebar.dispatch.on('elementClick', function(e) {
           form = document.getElementById('<%="form"+chartId%>');
-          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = e.pointIndex;
+          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = e.point.label;
           submitAjaxForm(form);
           });
        <% } %>

diff --git a/...shboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_line2chart_script.jsp b/...shboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_line2chart_script.jsp
@@ -96,7 +96,7 @@
   <% if( enableDrillDown ) {%>
     graph.lines.dispatch.on('elementClick', function(e) {
           form = document.getElementById('<%="form"+chartId%>');
-          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = e.pointIndex;
+          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = chartLabels<%=chartId%>[e.pointIndex];
           submitAjaxForm(form);
           });
   <% } %>

diff --git a/...ashboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_linechart_script.jsp b/...ashboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_linechart_script.jsp
@@ -86,7 +86,7 @@
   <% if( enableDrillDown ) {%>
     graph.lines.dispatch.on('elementClick', function(e) {
           form = document.getElementById('<%="form"+chartId%>');
-          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = e.pointIndex;
+          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = chartLabels<%=chartId%>[e.pointIndex];
           submitAjaxForm(form);
           });
   <% } %>

diff --git a/...dashboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_piechart_script.jsp b/...dashboard-ui-nvd3/src/main/webapp/components/bam/displayer/chart/nvd3_piechart_script.jsp
@@ -60,7 +60,7 @@
        <% if( enableDrillDown ) {%>
           graph.pie.dispatch.on('elementClick', function(e) {
           form = document.getElementById('<%="form"+chartId%>');
-          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = e.index;
+          form.<%= NVD3ChartViewer.PARAM_NSERIE %>.value = e.label;
           submitAjaxForm(form);
           });
        <% } %>