Added jQuery #1

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

EkoOne commented Nov 2, 2012

I think I did it. I just hope I didn't inadvertently do something wrong.

Todd added some commits Nov 2, 2012

Owner

walterdavis commented Nov 2, 2012

Formatting looks a little wonky in the JS, take a look at this: https://gist.github.com/a6e3a50f17e3c27c2073

Otherwise, it looks great.

Walter

On Nov 2, 2012, at 10:54 AM, ImXiiro wrote:

I think I did it. I just hope I didn't inadvertently do something wrong.

You can merge this Pull Request by running:

git pull https://github.com/ImXiiro/placeholder-shiv master
Or view, comment on, or merge it at:

#1

Commit Summary

• Initial commit.
• Initial commit.
File Changes

• A example/index.html (0)
• A example/index.jquery.html (26)
• A javascripts/placeholder-shiv.jquery.js (30)
Patch Links

https://github.com/walterdavis/placeholder-shiv/pull/1.patch
https://github.com/walterdavis/placeholder-shiv/pull/1.diff

Reply to this email directly or view it on GitHub.

Contributor

EkoOne commented Nov 2, 2012

Yeah, I did change the formatting when I was researching what each part did because it made more sense to me visually but I'm sure it's not correct. I'm still learning how to properly format js. I'm finding that what may be proper and what makes sense to me visually are usually different.

How should it be formatted?

Formatting looks a little wonky in the JS, take a look at this: https://gist.github.com/a6e3a50f17e3c27c2073

Otherwise, it looks great.

Owner

walterdavis commented Nov 2, 2012

Two spaces per level of indenting, and try to make the whole thing come out even in the end. Compare how mine looks in Gist with how yours looks in GitHub's source view:

https://github.com/ImXiiro/placeholder-shiv/blob/5b6f821605ff4363819e464ae14087362154ebe0/javascripts/placeholder-shiv.jquery.js

It's the mix of spaces and tabs that throws things all off. The diff ignores tabs and spaces (does a smart normalize) so it looks great there only.

Walter

On Nov 2, 2012, at 11:19 AM, ImXiiro wrote:

Yeah, I did change the formatting when I was researching what each part did because it made more sense to me visually but I'm sure it's not correct. I'm still learning how to properly format js. I'm finding that what may be proper and what makes sense to me visually are usually different.

How should it be formatted?

Formatting looks a little wonky in the JS, take a look at this: https://gist.github.com/a6e3a50f17e3c27c2073

Otherwise, it looks great.

Reply to this email directly or view it on GitHub.

Contributor

EkoOne commented Nov 2, 2012

Ah yes, huge difference. Much better.

On Nov 2, 2012, at 10:42 AM, walterdavis notifications@github.com wrote:

Two spaces per level of indenting, and try to make the whole thing come out even in the end. Compare how mine looks in Gist with how yours looks in GitHub's source view:

https://github.com/ImXiiro/placeholder-shiv/blob/5b6f821605ff4363819e464ae14087362154ebe0/javascripts/placeholder-shiv.jquery.js

It's the mix of spaces and tabs that throws things all off. The diff ignores tabs and spaces (does a smart normalize) so it looks great there only.

Walter

On Nov 2, 2012, at 11:19 AM, ImXiiro wrote:

Yeah, I did change the formatting when I was researching what each part did because it made more sense to me visually but I'm sure it's not correct. I'm still learning how to properly format js. I'm finding that what may be proper and what makes sense to me visually are usually different.

How should it be formatted?

Formatting looks a little wonky in the JS, take a look at this: https://gist.github.com/a6e3a50f17e3c27c2073

Otherwise, it looks great.

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

Owner

walterdavis commented Nov 2, 2012

Looks like you'll have to re-issue the pull request to get a new diff. Be sure to commit first with a tag of v0.2 so I can pull it in as a new version.

Walter

On Nov 2, 2012, at 11:50 AM, ImXiiro wrote:

Ah yes, huge difference. Much better.

On Nov 2, 2012, at 10:42 AM, walterdavis notifications@github.com wrote:

Two spaces per level of indenting, and try to make the whole thing come out even in the end. Compare how mine looks in Gist with how yours looks in GitHub's source view:

https://github.com/ImXiiro/placeholder-shiv/blob/5b6f821605ff4363819e464ae14087362154ebe0/javascripts/placeholder-shiv.jquery.js

It's the mix of spaces and tabs that throws things all off. The diff ignores tabs and spaces (does a smart normalize) so it looks great there only.

Walter

On Nov 2, 2012, at 11:19 AM, ImXiiro wrote:

Yeah, I did change the formatting when I was researching what each part did because it made more sense to me visually but I'm sure it's not correct. I'm still learning how to properly format js. I'm finding that what may be proper and what makes sense to me visually are usually different.

How should it be formatted?

Formatting looks a little wonky in the JS, take a look at this: https://gist.github.com/a6e3a50f17e3c27c2073

Otherwise, it looks great.

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

Contributor

EkoOne commented Nov 2, 2012

When you say commit with a tag, I don't see how to add a tag using the GitHub app. Or do I just add it in the "Commit Summary" field like so:

Be sure to commit first with a tag of v0.2 so I can pull it in as a new version.

Owner

walterdavis commented Nov 2, 2012

What tool are you using for git? If you're in the command-line, just type the following:

git tag 'v0.2'

That should be enough to get started. Then commit while you are "in" that tag, push to origin, and create a new pull request on Github.

Walter

On Nov 2, 2012, at 12:52 PM, ImXiiro wrote:

When you say commit with a tag, I don't see how to add a tag using the GitHub app. Or do I just add it in the "Commit Summary" field like so:

Be sure to commit first with a tag of v0.2 so I can pull it in as a new version.

Reply to this email directly or view it on GitHub.

Contributor

EkoOne commented Nov 2, 2012

I'm using the GitHub app http://mac.github.com.

On Nov 2, 2012, at 12:34 PM, walterdavis notifications@github.com wrote:

What tool are you using for git? If you're in the command-line, just type the following:

git tag 'v0.2'

That should be enough to get started. Then commit while you are "in" that tag, push to origin, and create a new pull request on Github.

Walter

On Nov 2, 2012, at 12:52 PM, ImXiiro wrote:

When you say commit with a tag, I don't see how to add a tag using the GitHub app. Or do I just add it in the "Commit Summary" field like so:

Be sure to commit first with a tag of v0.2 so I can pull it in as a new version.

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

Owner

walterdavis commented Nov 2, 2012

Hmm, then I'll add the tag later. I don't see any easy way to add it in that tool. I alternate between the command-line and GitBox, personally.

Walter

On Nov 2, 2012, at 1:50 PM, ImXiiro wrote:

I'm using the GitHub app http://mac.github.com.

On Nov 2, 2012, at 12:34 PM, walterdavis notifications@github.com wrote:

What tool are you using for git? If you're in the command-line, just type the following:

git tag 'v0.2'

That should be enough to get started. Then commit while you are "in" that tag, push to origin, and create a new pull request on Github.

Walter

On Nov 2, 2012, at 12:52 PM, ImXiiro wrote:

When you say commit with a tag, I don't see how to add a tag using the GitHub app. Or do I just add it in the "Commit Summary" field like so:

Be sure to commit first with a tag of v0.2 so I can pull it in as a new version.

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

Contributor

EkoOne commented Nov 2, 2012

I have GitBox laying around, I'll try it.

Hmm, then I'll add the tag later. I don't see any easy way to add it in that tool. I alternate between the command-line and GitBox, personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment