Skip to content

style: apply /style-guide pass to snippets/_includes#2736

Open
johndmulhausen wants to merge 4 commits into
mainfrom
style-guide/snippets-includes-20260605-162100
Open

style: apply /style-guide pass to snippets/_includes#2736
johndmulhausen wants to merge 4 commits into
mainfrom
style-guide/snippets-includes-20260605-162100

Conversation

@johndmulhausen

Copy link
Copy Markdown
Contributor

Summary

This PR applies the /style-guide skill (Google Developer Style Guide + CoreWeave conventions) to 39 files under snippets/_includes. The run was automated; edits are style-only and preserve technical meaning.

Files edited

  • snippets/_includes/api-key-create-streamlined.mdx
  • snippets/_includes/api-key-create.mdx
  • snippets/_includes/api-key-find.mdx
  • snippets/_includes/api-key-security.mdx
  • snippets/_includes/api-key-view-once-warning.mdx
  • snippets/_includes/automations/actions-list.mdx
  • snippets/_includes/automations/best-practices.mdx
  • snippets/_includes/automations/tutorial-go-further.mdx
  • snippets/_includes/byob-provisioning-link.mdx
  • snippets/_includes/cli/README.md
  • snippets/_includes/cli/wandb-beta-leet.mdx
  • snippets/_includes/code-examples/runs_update_tag_public_api.mdx
  • snippets/_includes/line-plot-capture-groups.mdx
  • snippets/_includes/llm-eval-jobs/export-evaluation.mdx
  • snippets/_includes/llm-eval-jobs/preview.mdx
  • snippets/_includes/llm-eval-jobs/rerun-evaluation.mdx
  • snippets/_includes/llm-eval-jobs/review-evaluation-results.mdx
  • snippets/_includes/multi-tenant-cloud-only.mdx
  • snippets/_includes/object-storage-configuration-intro.mdx
  • snippets/_includes/org-service-account-create.mdx
  • snippets/_includes/pinned-and-baseline-runs/pin-runs-condensed.mdx
  • snippets/_includes/project-visibility-settings.mdx
  • snippets/_includes/public-api-use.mdx
  • snippets/_includes/rate-limits-defaults-and-notification.mdx
  • snippets/_includes/release-notes-support-eol-reminder.mdx
  • snippets/_includes/self-managed-mysql-database-creation.mdx
  • snippets/_includes/self-managed-mysql-requirements.mdx
  • snippets/_includes/self-managed-networking-requirements.mdx
  • snippets/_includes/self-managed-object-storage-requirements.mdx
  • snippets/_includes/self-managed-obtain-license.mdx
  • snippets/_includes/self-managed-redis-requirements.mdx
  • snippets/_includes/self-managed-ssl-tls-requirements.mdx
  • snippets/_includes/self-managed-verify-installation.mdx
  • snippets/_includes/service-account-api-key-create-additional-single-tenant.mdx
  • snippets/_includes/service-account-api-key-create-additional.mdx
  • snippets/_includes/service-account-api-key-delete.mdx
  • snippets/_includes/service-account-benefits.mdx
  • snippets/_includes/team-service-account-create.mdx
  • snippets/_includes/weave-quickstart-prereqs.mdx

Recommendations for technical review

UI labels, paths, and surfaces

  • Verify "Weave for Agents" is the current product name and that "Agents view" matches the actual UI surface (vs. "Agents page" / "Agents dashboard") in automations/* / Weave snippets.
  • Confirm https://wandb.ai/settings is the canonical destination for API key creation, that "User Settings" matches the current UI label, and that the snippet's hardcoded wandb.ai host is appropriate for Dedicated Cloud / W&B Server contexts (api-key-create-streamlined.mdx, api-key-create.mdx, api-key-find.mdx).
  • Confirm "user profile icon" → "User Settings" is a single menu/dropdown path (vs. two unrelated interactions) before keeping the > separator form (api-key-find.mdx, api-key-create.mdx).
  • Verify "organization settings" is the accurate location label and that API Keys is still the correct tab name and casing (api-key-create.mdx).
  • Confirm "Service Accounts" is a tab (not a page/section) and that the ellipsis "action menu" matches the current UI label (org-service-account-create.mdx, service-account-api-key-create-additional.mdx, service-account-api-key-create-additional-single-tenant.mdx, service-account-api-key-delete.mdx, team-service-account-create.mdx).
  • In service-account-api-key-delete.mdx, verify the actual delete affordance (named button vs. trash icon) and reconcile link text "Organization settings" with destination https://wandb.ai/account-settings/.
  • Confirm the API-key creation surface is a dialog/modal (vs. page/drawer) and that "settings" is the correct surface where the key ID remains visible (api-key-view-once-warning.mdx).
  • Confirm the Automations location asymmetry between project sidebar and registry surfaces, and whether team/org-level entry points should also be listed (automations/*).
  • Confirm "the download button" in llm-eval-jobs/export-evaluation.mdx — bold the verbatim label if one exists.
  • Confirm "drawer," "the play icon," and the #evaluate-your-model anchor in llm-eval-jobs/rerun-evaluation.mdx; verify Mintlify renders the nested 1. 1. 1. Markdown auto-numbering correctly.
  • Verify the icon classes in pinned-and-baseline-runs/pin-runs-condensed.mdx (fa-regular fa-eye to hide, fa-solid fa-eye-closed to show) — easy to swap by mistake. Also confirm pin limits (six runs total / five with a baseline).
  • Verify "the emoji icon or the chat icon in the Feedback column" and the /weave/guides/core-types/leaderboards cross-reference in llm-eval-jobs/review-evaluation-results.mdx.

Product/feature accuracy

  • Confirm the LLM Evaluation Jobs public-preview status (and scoping to Multi-tenant Cloud only), free-compute statement, and that "Launch pricing" / /models/launch#pricing is the right destination (llm-eval-jobs/preview.mdx).
  • Verify Slack webhook payload claims (JSON content type, link back to W&B for the triggering event) and that the action-type list is complete in automations/actions-list.mdx.
  • Verify deployment-type scope labels for BYOB (Team-level vs. Instance + team-level) and consider expanding BYOB on first use (object-storage-configuration-intro.mdx, byob-provisioning-link.mdx).
  • Verify the BYOB guide at /platform/hosting/data-security/secure-storage-connector actually covers all five listed storage types (object-storage-configuration-intro.mdx).
  • Verify visibility-change semantics in project-visibility-settings.mdx, including whether re-invitation behavior differs by source/target combination, and that /models/reports/collaborate-on-reports#share-a-report resolves.
  • Confirm rate-limits table consistency in rate-limits-defaults-and-notification.mdx: align the duplicate "Filestream requests per second" row labels (Project vs. Run) and the SDK error string (HTTP 429: rate limited exceeded vs. rate limit exceeded).
  • Spell out the consequence of running an out-of-support release and clarify whether subsequent patch releases extend the 12-month window in release-notes-support-eol-reminder.mdx.
  • Verify Bufstream capitalization, the gcr.io plural-registries note, and the air-gapped link target /platform/hosting/self-managed/on-premises-deployments/kubernetes-airgapped in self-managed-networking-requirements.mdx.

Self-managed requirements

  • Verify supported MySQL/Aurora minimums and managed-database options (AWS RDS Aurora MySQL, Google Cloud SQL for MySQL, Azure Database for MySQL); clean up the ambiguous "v8.0.x is required, v8.0.32 or newer" phrasing (self-managed-mysql-requirements.mdx).
  • Confirm "Redis 7.x," single-node topology, and whether the bundled local Redis still ships; also correct vendor branding (Amazon ElastiCache, Google Cloud Memorystore) (self-managed-redis-requirements.mdx).
  • Confirm S3-compatible object storage requirements (pre-signed URLs, CORS, Signature V4, multipart), maintenance-mode status for MinIO Open Source, and current path/anchor links (self-managed-object-storage-requirements.mdx).
  • Verify "Intel (x86)" wording and consider clarifying ARM-not-supported as a callout in parent docs (self-managed-networking-requirements.mdx and related).
  • Confirm SQL placeholder readability ('<password>') and intentional host wildcard (wandb_local@'%') in self-managed-mysql-database-creation.mdx.
  • Confirm version floors and link targets in the requirements table (Kubernetes v1.34, Helm v3.x, Redis v7.x) (self-managed-verify-installation.mdx and self-managed-mysql-requirements.mdx).
  • Clarify "challenges for users" and define "custom CAs" on first use in self-managed-ssl-tls-requirements.mdx; consider noting Istio/sidecar caveats.
  • Verify the self-managed-verify-installation.mdx Note links to admin-account creation, explicitly explains the YOUR_DNS_DOMAIN placeholder, and adds per-check troubleshooting or a support link.
  • Confirm the W&B signup destination and license-download/copy guidance in self-managed-obtain-license.mdx.

Security and credentials

  • Consider explicitly stating "the API key is only displayed once on creation" inside the streamlined snippet so the urgency is self-contained (api-key-create-streamlined.mdx).
  • Verify guidance to "save it in a secure location such as a password manager" still aligns with current W&B security guidance (secrets managers, netrc); reconsider the export ... Warning block syntax and the "in line with the command" phrasing in api-key-security.mdx.
  • Verify SDK version cutoffs (wandb v0.22.3+, weave v0.52.17+), expand AISE on first use, and add a wandb login --relogin / key-rotation pointer (api-key-security.mdx, release-notes-support-eol-reminder.mdx).
  • Confirm the admin-permission matrix for Dedicated Cloud and Self-Managed in api-key-create.mdx, and verify "key ID (the first part of each API key)" is technically accurate.
  • Confirm that service-account key creation snippets explicitly note the "view once" reveal behavior or compose in ApiKeyViewOnceWarning (service-account-api-key-create-additional.mdx, service-account-api-key-create-additional-single-tenant.mdx, org-service-account-create.mdx, team-service-account-create.mdx).
  • Verify the "Federated Identity vs. Generate API key" behavior and post-creation verification step in team-service-account-create.mdx.
  • Make service-account-benefits.mdx bullet descriptions parallel and replace marketing framing ("Enterprise-ready," "Built for production automation at scale") with concrete capabilities.

Content/structure

  • Consider linking the public-preview snippet to a "what may change" / stability-guarantees page and removing the snippet at GA (llm-eval-jobs/preview.mdx).
  • Verify WB-34263 (Python SDK create_automation regression) status so the commented-out bullets in automations/tutorial-go-further.mdx can be restored; confirm /models/automations/automation-events and related anchors.
  • Confirm the Mermaid init directive ('rankSpacing': 200;) renders in the docs site's Mermaid version in automations/best-practices.mdx-adjacent diagrams; clarify ambiguous bullets ("test project or with a test webhook," severity-based routing).
  • Verify <TutorialDiagramProject/> and <TutorialDiagramRegistry/> render correctly when indented inside list items (automations/tutorial-go-further.mdx).
  • Confirm the cli/README.md "How it works" template is shown or linked, that the generator-run trigger is documented, and that local-preview instructions are linked.
  • Sanity-check the wide-ranging technical claims in cli/wandb-beta-leet.mdx (LEET config precedence with XDG_CONFIG_HOME, per_series palette key, changelog repo link, pin vs. highlight semantics, live-run polling, tail-window default, Hopper scoping, "tensorcore" capitalization, media pane arrow-key behavior, 0.23.1 cell run-on, completeness of shortcut tables, bare-term filter scope).
  • In code-examples/runs_update_tag_public_api.mdx, confirm whether run.tags is a tuple (matches docstring + += ("<tag3>",) usage) and that <entity>, <project>, <tag1..3> placeholder conventions match siblings.
  • Verify Mintlify renders the trailing period outside the link text in multi-tenant-cloud-only.mdx, and that the snippet reads as a complete thought across every include site (or rewrite to a full sentence).
  • Confirm "This feature" remains unambiguous across all include sites for enterprise-only.mdx-style snippets (referenced from style passes).
  • Verify cross-reference anchor #wb-multi-tenant-cloud on /platform/hosting/ (multi-tenant-cloud-only.mdx).
  • Confirm line-plot capture-group examples accurately reflect current metric-name validation rules — especially the leading-digit disqualifier for 5_fold_cv (line-plot-capture-groups.mdx).
  • In public-api-use.mdx, confirm whether "should match" the metric-name regex should be tightened to "must match," and consider documenting maximum length / reserved-name restrictions.
  • In weave-quickstart-prereqs.mdx, verify supported version floors (Python 3.10+, Node.js 18+), canonical install commands, and whether to name the OPENAI_API_KEY env var explicitly.

How to review

  • Each file's changes are style edits only. Compare side-by-side and flag any that change technical meaning.
  • Approve and merge to accept the edits, or close to reject them.

@mintlify

mintlify Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
wandb 🟢 Ready View Preview Jun 5, 2026, 8:38 PM

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies an automated /style-guide pass (Google Developer Style Guide + CoreWeave conventions) across documentation includes under snippets/_includes, with edits intended to be style-only while preserving meaning.

Changes:

  • Standardizes wording, punctuation, and sentence structure across many include snippets.
  • Improves clarity in step-by-step UI instructions and short reference notes.
  • Normalizes formatting of lists and code blocks in self-managed / CLI-related snippets.

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
snippets/_includes/api-key-create-streamlined.mdx Rewords streamlined API key creation note for clarity.
snippets/_includes/api-key-create.mdx Adjusts personal API key creation step wording/format.
snippets/_includes/api-key-find.mdx Clarifies API key lookup instructions and “view once” behavior wording.
snippets/_includes/api-key-security.mdx Expands secure storage guidance; updates examples and SDK compatibility notes.
snippets/_includes/api-key-view-once-warning.mdx Refines “view once” warning wording.
snippets/_includes/automations/actions-list.mdx Rephrases Slack/webhook action descriptions for consistency.
snippets/_includes/automations/best-practices.mdx Minor wording tweaks to automation best-practice bullets.
snippets/_includes/automations/tutorial-go-further.mdx Rewords intro sentence for “go further” resource links.
snippets/_includes/byob-provisioning-link.mdx Tightens provisioning lead-in sentence and link intro wording.
snippets/_includes/cli/README.md Rewords/structures contributor guidance for CLI intro snippets.
snippets/_includes/cli/wandb-beta-leet.mdx Large set of style/clarity edits across LEET CLI documentation.
snippets/_includes/code-examples/runs_update_tag_public_api.mdx Clarifies explanatory text for the Public API tags example.
snippets/_includes/line-plot-capture-groups.mdx Small wording tweak in capture-group example explanation.
snippets/_includes/llm-eval-jobs/export-evaluation.mdx Rephrases export instructions; adjusts step wording.
snippets/_includes/llm-eval-jobs/preview.mdx Adjusts preview note wording/link text.
snippets/_includes/llm-eval-jobs/rerun-evaluation.mdx Expands intro and refines re-run instructions wording.
snippets/_includes/llm-eval-jobs/review-evaluation-results.mdx Refines leaderboard export instructions wording.
snippets/_includes/multi-tenant-cloud-only.mdx Shortens availability note wording.
snippets/_includes/object-storage-configuration-intro.mdx Adds terminal punctuation; rephrases bullets slightly.
snippets/_includes/org-service-account-create.mdx Splits/clarifies navigation steps; condenses subsequent steps.
snippets/_includes/pinned-and-baseline-runs/pin-runs-condensed.mdx Rewords pinning limits/behavior sentence for consistency.
snippets/_includes/project-visibility-settings.mdx Refines “Open” visibility guidance and note wording.
snippets/_includes/public-api-use.mdx Rephrases callout to be more direct/active voice.
snippets/_includes/rate-limits-defaults-and-notification.mdx Adds an explanatory lead-in sentence and refines bullet wording.
snippets/_includes/release-notes-support-eol-reminder.mdx Reorders/supports EOL reminder note wording.
snippets/_includes/self-managed-mysql-database-creation.mdx Updates placeholder wording in SQL example intro and statement.
snippets/_includes/self-managed-mysql-requirements.mdx Minor wording/whitespace cleanup and link sentence clarity.
snippets/_includes/self-managed-networking-requirements.mdx Rewords egress guidance and note copy for readability.
snippets/_includes/self-managed-object-storage-requirements.mdx Reworks provider list phrasing and surrounding guidance text.
snippets/_includes/self-managed-obtain-license.mdx Clarifies trial/license acquisition steps and bullet punctuation.
snippets/_includes/self-managed-redis-requirements.mdx Rephrases Redis requirements and environment list item wording.
snippets/_includes/self-managed-ssl-tls-requirements.mdx Rewords TLS requirements and guidance sentences for clarity.
snippets/_includes/self-managed-verify-installation.mdx Improves structure/indentation of verify instructions and code blocks.
snippets/_includes/service-account-api-key-create-additional-single-tenant.mdx Small wording updates to steps (create key + naming).
snippets/_includes/service-account-api-key-create-additional.mdx Rephrases first step for clarity.
snippets/_includes/service-account-api-key-delete.mdx Minor sentence tightening in key deletion steps.
snippets/_includes/service-account-benefits.mdx Adds consistent punctuation and contractions in benefit bullets.
snippets/_includes/team-service-account-create.mdx Condenses steps and improves consistency of UI label emphasis.
snippets/_includes/weave-quickstart-prereqs.mdx Adds terminal punctuation to the OpenAI key prerequisite.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread snippets/_includes/api-key-security.mdx
Comment thread snippets/_includes/rate-limits-defaults-and-notification.mdx Outdated
Comment thread snippets/_includes/self-managed-networking-requirements.mdx Outdated
Comment thread snippets/_includes/self-managed-networking-requirements.mdx Outdated
Comment thread snippets/_includes/self-managed-redis-requirements.mdx Outdated
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📚 Mintlify Preview Links

🔗 View Full Preview

📝 Changed (39 total)

📄 Pages (38)

File Preview
snippets/_includes/api-key-create-streamlined.mdx Api Key Create Streamlined
snippets/_includes/api-key-create.mdx Api Key Create
snippets/_includes/api-key-find.mdx Api Key Find
snippets/_includes/api-key-security.mdx Api Key Security
snippets/_includes/api-key-view-once-warning.mdx Api Key View Once Warning
snippets/_includes/automations/actions-list.mdx Actions List
snippets/_includes/automations/best-practices.mdx Best Practices
snippets/_includes/automations/tutorial-go-further.mdx Tutorial Go Further
snippets/_includes/byob-provisioning-link.mdx Byob Provisioning Link
snippets/_includes/cli/wandb-beta-leet.mdx Wandb Beta Leet
... and 28 more files
⚙️ Other (1)
File
snippets/_includes/cli/README.md

🤖 Generated automatically when Mintlify deployment succeeds
📍 Deployment: b74d17d at 2026-06-05 21:59:47 UTC

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🔗 Link Checker Results

All links are valid!

No broken links were detected.

Checked against: https://wb-21fd5541-style-guide-snippets-includes-20260605-162100.mintlify.app

- api-key-security: drop `export` from the inline env-var anti-pattern
  (invalid shell: `export VAR=... cmd` treats `cmd` as an arg to export),
  and use `<your-api-key>` angle-bracket placeholder
- rate-limits: fix SDK log message `rate limited exceeded` ->
  `rate limit exceeded` to match the example block and the actual SDK string
- self-managed-networking: wrap egress endpoint URLs in backticks and drop a
  stray trailing period so autolinkers can't absorb punctuation
- self-managed-redis: correct vendor branding to Amazon ElastiCache and
  Google Cloud Memorystore

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Partially reverts 6d744f5. The block is a labeled "avoid this pattern"
example that readers are explicitly told not to run, and the original
`export WANDB_API_KEY=... ./my-script.sh` form better conveys the intended
"don't put the key inline with the command" warning. Copilot's point that
`export VAR=val cmd` isn't a valid run-the-script invocation is correct but
moot for a "don't do this" snippet.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Per repo-owner decision, wandb/docs adopts the CoreWeave /style-guide
bracket-style uppercase placeholder convention ([ALL-CAPS-HYPHENATED]).
Reverts the angle-bracket form introduced in 6d744f5.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants