Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk): Package wandb with wandb-core #7381

Merged
merged 19 commits into from
Apr 16, 2024

Conversation

timoffex
Copy link
Contributor

@timoffex timoffex commented Apr 15, 2024

Description

Includes the wandb-core binary in the wandb wheel, deprecating the wandb-core package.

Now we only have one package!

Some notes:

  • We now use hatch to build wandb instead of setuptools
    • I removed the MANIFEST.in files which were for setuptools
  • pip install . will compile the wandb-core Go binary
    • This can be turned off by setting the WANDB_BUILD_UNIVERSAL=true environment variable
    • Use pip wheel to build a wheel (this calls python -m build, except it also installs build deps)
    • I removed wini as we no longer need it!
  • We now build platform-specific wandb wheels and a universal one
    • Since we continue to build a universal wheel, and since we don't require wandb-core just yet, this should be transparent to all users
    • Users on supported platforms can use wandb.require("core") without any additional installs
    • Everything is set up to allow for uploading source distributions in the future

Testing

Successful release-sdk run: https://github.com/wandb/wandb/actions/runs/8697668570

Created using spr 1.3.5
Copy link

socket-security bot commented Apr 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/hatchling@1.23.0 environment, eval, filesystem, network, shell +2 465 kB Ofekmeister

🚮 Removed packages: pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/grpcio@1.63.0rc1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/libcst@1.3.1, pypi/pytest-openfiles@0.5.0, pypi/pytest-openfiles@0.5.0, pypi/twine@5.0.0, pypi/twine@5.0.0, pypi/wandb-core@0.17.0b9, pypi/wandb-core@0.17.0b9, pypi/wandb-core@0.17.0b9, pypi/wandb-core@0.17.0b9, pypi/wandb-core@0.17.0b9, pypi/wheel@0.43.0, pypi/wheel@0.43.0

View full report↗︎

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@6a3cc89). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7381   +/-   ##
=======================================
  Coverage        ?   67.40%           
=======================================
  Files           ?      517           
  Lines           ?    54509           
  Branches        ?        0           
=======================================
  Hits            ?    36740           
  Misses          ?    17383           
  Partials        ?      386           
Flag Coverage Δ
func 41.81% <84.21%> (?)
system 57.82% <84.21%> (?)
unit 45.09% <78.94%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/monitor/gpu_apple.go 11.02% <100.00%> (ø)
wandb/__init__.py 95.65% <ø> (ø)
wandb/env.py 79.31% <100.00%> (ø)
wandb/sdk/service/service.py 79.68% <100.00%> (ø)
wandb/util.py 79.08% <75.00%> (ø)

Created using spr 1.3.5
Created using spr 1.3.5
Created using spr 1.3.5
pyproject.toml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@timoffex timoffex marked this pull request as ready for review April 16, 2024 18:42
@timoffex timoffex requested a review from a team as a code owner April 16, 2024 18:42
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kptkin
Copy link
Collaborator

kptkin commented Apr 16, 2024

Huge milestone!

Created using spr 1.3.5
@timoffex timoffex merged commit e6abc7b into main Apr 16, 2024
62 of 67 checks passed
@timoffex timoffex deleted the spr/timoffex/refactorsdk-package-wandb-with-wandb-core branch April 16, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants