Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev): Fixes for menu items in report commands popup #1644

Merged
merged 13 commits into from
May 21, 2024
Merged

chore(dev): Fixes for menu items in report commands popup #1644

merged 13 commits into from
May 21, 2024

Conversation

onx2
Copy link
Contributor

@onx2 onx2 commented May 15, 2024 •
edited
Loading

https://wandb.atlassian.net/browse/WB-18453

  • Refactors the WBMenu so that the first item can be highlights.
  • Simplify some of the logic for keyboard navigation
  • Remove unused props
  • Removes mutating props (I see we had unique only for this, if we want to keep that overriding behavior I can add it back in not as a mutation.)

@onx2 onx2 requested review from a team as code owners May 15, 2024 20:10
@onx2 onx2 self-assigned this May 15, 2024
@circle-job-mirror
Copy link

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0fa3a822d4ad2e023a1eeb0fb6206a14ac21a77e

2 similar comments
@circle-job-mirror
Copy link

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0fa3a822d4ad2e023a1eeb0fb6206a14ac21a77e

@circle-job-mirror
Copy link

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0fa3a822d4ad2e023a1eeb0fb6206a14ac21a77e

gtarpenning
gtarpenning reviewed May 15, 2024
View reviewed changes
Copy link
Member

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if I can stamp, lowkey a bit out of my wheelhouse

weave-js/tsconfig.json Outdated Show resolved Hide resolved
weave-js/src/common/components/WBMenu.tsx Outdated Show resolved Hide resolved
weave-js/src/common/components/WBMenu.tsx Outdated Show resolved Hide resolved
weave-js/src/common/components/WBMenu.tsx Show resolved Hide resolved
@onx2 onx2 requested a review from gtarpenning May 15, 2024 22:18
gtarpenning
gtarpenning approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@gtarpenning gtarpenning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through the functionality with Jeff, seems safe, as long as the callsites on the menu now pass in unique options.

connieelee
connieelee approved these changes May 20, 2024
View reviewed changes
weave-js/src/common/components/WBMenu.tsx Outdated Show resolved Hide resolved
@onx2 onx2 merged commit f697fd4 into master May 21, 2024
24 checks passed
@onx2 onx2 deleted the onx2/WB-18453 branch May 21, 2024 17:13
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connieelee connieelee connieelee approved these changes

@gtarpenning gtarpenning gtarpenning approved these changes

Assignees

@onx2 onx2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onx2 @connieelee @gtarpenning