Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Add cost table to summary tab #1766

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

jwlee64
Copy link
Contributor

@jwlee64 jwlee64 commented Jun 12, 2024

Screenshot 2024-06-12 at 2 41 04 PM
Screenshot 2024-06-12 at 2 42 08 PM

@jwlee64 jwlee64 requested a review from a team as a code owner June 12, 2024 21:27
@jwlee64 jwlee64 changed the base branch from master to add-trace-usage-stats June 12, 2024 21:27
import {CostTable} from './CostTable';
import {UsageData} from './TraceUsageStats';

const SUMMARY_FIELDS_EXCLUDED_FROM_GENERAL_RENDER = ['_latency_s', 'usage'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscored _latency_s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo my b

Base automatically changed from add-trace-usage-stats to master June 12, 2024 22:55
@jwlee64 jwlee64 merged commit c333df2 into master Jun 12, 2024
25 checks passed
@jwlee64 jwlee64 deleted the cost-sumamry-table branch June 12, 2024 23:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants