Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for bbdb-3.x #64

Open
p5n opened this issue Jun 10, 2014 · 8 comments
Open

support for bbdb-3.x #64

p5n opened this issue Jun 10, 2014 · 8 comments
Labels

Comments

@p5n
Copy link

@p5n p5n commented Jun 10, 2014

http://bbdb.sourceforge.net/ says that new homepage (and new developer) of bbdb is http://savannah.nongnu.org/projects/bbdb/

bbdb-3.1.2 released on Apr 27, 2014. It contains major changes (for example bbdb-hooks file removed)

Could you please support latest bbdb version ?

@p5n

This comment has been minimized.

Copy link
Author

@p5n p5n commented Jun 10, 2014

at least utils/bbdb-wl.el needs changes

@cnngimenez

This comment has been minimized.

Copy link

@cnngimenez cnngimenez commented Jun 14, 2014

I have done something for BBDBv3-Wl, but I don't know if you like it.

The main site is at gna, but I made more updates at the bitbucket.

Cheers!

@dmj

This comment has been minimized.

Copy link
Member

@dmj dmj commented Jul 6, 2014

There also is https://github.com/dmj/bbdbv3/tree/t/wanderlust with a hacked up elderly version of BBDB with some preliminary WL support (complete names when composing messages).

@dmj dmj added the feature label Jul 13, 2014
@ddoherty03

This comment has been minimized.

Copy link

@ddoherty03 ddoherty03 commented Oct 12, 2016

I up-vote this as well.

@biffhero

This comment has been minimized.

Copy link

@biffhero biffhero commented Sep 3, 2017

I looked at this over the last couple of days. Here is what I did, and where I am stuck.

  1.  (wl wl-summary-mode wl-draft-mode mime-view-mode) - bbdb-mua.el in the 
    

(defconst bbdb-mua-mode-alist
This is because there are checks to see what mode the message buffer is in before bbdb will go into the buffer and grab addresses and things

  1. inside of bbdb-mua(), I commented out most logic, and inserted
    (setq mua 'wl) - bbdb-mua.el , just above the (or mua)) clause
    This is because I don't understand what bbdb-mua() is doing to parse the constant at bbdb-mua-mode-alist. I tried faking it elsewhere, but I kept coming back to (bbdb-mua()) needing to be successful, and until it returned 'wl, everything was bad.

  2. inside of bbdb-get-address-components(), there's a call to (bbdb-message-header), but all that does (for me) is the following: ((eq mua 'wl) (bbdb/wl-header header))
    So I'm currently looking more closely at (defun bbdb/wl-header (header) in the file ~/.emacs.d/elpa/bbdb-20170725.300/bbdb-wl.el , and that's where I'm getting lost. I think the problem is
    (defun bbdb/wl-header (header)
    (elmo-message-entity-field
    (elmo-message-entity wl-summary-buffer-elmo-folder
    (wl-summary-message-number))
    (intern (downcase header)) 'string))
    So, since I don't understand that at all, I'm trying to write simple things like this:
    (if (eq header "From")
    "Rob Walker rob@ladle.net")
    and doing that for all headers. That way I can tell that I'm in the correct place or not.

It's probably pretty obvious that I don't understand elisp very well, but I hope that this helps someone out a little bit.

Is there an IRC channel for this new WL?

@tobytripp

This comment has been minimized.

Copy link

@tobytripp tobytripp commented May 9, 2018

Any updates on this issue?

@biffhero

This comment has been minimized.

Copy link

@biffhero biffhero commented May 11, 2018

@tobytripp , I am idling on #wanderlust on freenode. I have BBDBv3 + WL working well. It only required two small changes in the BBDB code.

  1. In bbdb-mua.el, inside of the (defconst bbdb-mua-mode-alist

    (wl mime-view-mode wl-summary-mode wl-draft-mode)

  2. In bbdb-wl.el, change one function.

;;;###autoload
(defun bbdb/wl-header (header)
(with-current-buffer (get-buffer wl-summary-buffer-name)
(elmo-message-entity-field
(elmo-message-entity wl-summary-buffer-elmo-folder
(wl-summary-message-number))
(intern (downcase header)) 'string)))

After that, my configs worked fine.

@tobytripp

This comment has been minimized.

Copy link

@tobytripp tobytripp commented May 11, 2018

Thanks, I'll give that a try. At this point I'm just wondering if these fixes will appear in the packages themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.