add explicit rspec require in spec_helper #64

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@pravi

pravi commented Oct 18, 2012

It is required for automatic building of debian packages from the gem file.

@josevalim

This comment has been minimized.

Show comment
Hide comment
@josevalim

josevalim Mar 2, 2013

Collaborator

It is not meant to. Which command are you using to run tests?

Collaborator

josevalim commented Mar 2, 2013

It is not meant to. Which command are you using to run tests?

@JonRowe

This comment has been minimized.

Show comment
Hide comment
@JonRowe

JonRowe Mar 3, 2013

Contributor

Agree with @josevalim, this shouldn't be necessary, RSpec is the only thing that should be loading the spec_helper and thus already is loaded. This shouldn't be loaded by any package based on it, if it is your intention to distribute Warden via a .deb and this is causing you issues, consider fixing your build process to exclude test files. Or if you are trying to run the tests as part of a build/deploy process, consider making rspec and rake a dependency of your package and running the tests as they are meant to be.

Contributor

JonRowe commented Mar 3, 2013

Agree with @josevalim, this shouldn't be necessary, RSpec is the only thing that should be loading the spec_helper and thus already is loaded. This shouldn't be loaded by any package based on it, if it is your intention to distribute Warden via a .deb and this is causing you issues, consider fixing your build process to exclude test files. Or if you are trying to run the tests as part of a build/deploy process, consider making rspec and rake a dependency of your package and running the tests as they are meant to be.

@hassox

This comment has been minimized.

Show comment
Hide comment
@hassox

hassox Mar 12, 2013

Collaborator

Is this still a problem or are you able to update the debian package?

Collaborator

hassox commented Mar 12, 2013

Is this still a problem or are you able to update the debian package?

@pravi

This comment has been minimized.

Show comment
Hide comment

@pravi pravi closed this Mar 13, 2013

@hassox

This comment has been minimized.

Show comment
Hide comment
@hassox

hassox Mar 14, 2013

Collaborator

Great thanks :)

Collaborator

hassox commented Mar 14, 2013

Great thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment