Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `build` command to build a specific version of a package on warehouse #13

Merged
merged 6 commits into from Jun 25, 2019

Conversation

@wjarvis1
Copy link
Contributor

commented Jun 21, 2019

Add build command to build a specific version of a package on warehouse

Summary

Need a build command in the cli to build a specific version of a package on warehouse.

Changelog

Add build command to build a specific version of a package on warehouse, and optionally promote with -m flag

Test Plan

README.md Show resolved Hide resolved

@burgessa23 burgessa23 requested a review from fritzmonkey Jun 21, 2019

README.md Show resolved Hide resolved
src/base.js Outdated
/**
* Builds a missing version error message
*
* @returns {string} The missing host error message

This comment has been minimized.

Copy link
@fritzmonkey

fritzmonkey Jun 21, 2019

Contributor
Suggested change
* @returns {string} The missing host error message
* @returns {string} The missing version number error message
return resolve(JSON.stringify(response));
}

this.log('Build triggered successfully. See `get:status` command to get the status of a build.');

This comment has been minimized.

Copy link
@fritzmonkey

fritzmonkey Jun 21, 2019

Contributor

Since we have the information, we should build the full wrhs get:status command for easy copying.

wjarvis1 added 2 commits Jun 21, 2019
[test] Corrected extra 'v' in front of tag number generated in README…
…, updated build command to log the built status command for easy copying. Updated tests for build command.

@burgessa23 burgessa23 requested a review from fritzmonkey Jun 24, 2019

@wjarvis1 wjarvis1 merged commit 8db2329 into warehouseai:master Jun 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.