Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsondump option to wwsh object #145

Merged
merged 3 commits into from Feb 4, 2019
Merged

Conversation

azenk
Copy link

@azenk azenk commented Sep 21, 2018

In order to facilitate automated sync of our warewulf configuration with other databases and provisioning systems, we needed a mechanism for reading from the warewulf database in a language agnostic way. This pull request adds support for a jsondump option to wwsh object allowing our tools to easily read the existing state and act accordingly.

I'm not a particularly experienced perl developer. So please be gentle...

@azenk azenk changed the base branch from master to development September 23, 2018 13:42
Adds a jsondump command for `wwsh object` to facilitate integration with external tools.
@bensallen
Copy link
Member

Hi @azenk thanks for the PR. Hope to get some time soon to review.

@@ -445,6 +445,19 @@ get_hash()
return ((wantarray()) ? (%{$hashref}) : ($hashref));
}

=item TO_JSON()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should TO_JSON be capitalized?

@bensallen
Copy link
Member

Thank @azenk! Going to accept these changes since my only nit was capitalization.

@bensallen bensallen merged commit e3a5221 into warewulf:development Feb 4, 2019
macdems pushed a commit to macdems/warewulf3 that referenced this pull request Sep 27, 2020
Adds a jsondump command for `wwsh object` to facilitate integration with external tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants