Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.x Immediate Bug Fix Reports #535

Closed
Nicholas-Cardot opened this issue May 9, 2018 · 56 comments

Comments

Projects
None yet
@Nicholas-Cardot
Copy link
Collaborator

commented May 9, 2018

Use this issue to post any bugs or glitches in the 3.0.x system. We will fix them as quickly as possible and release a 3.0.9 patch as needed to fix anything reported here.

Bugs to Solve for 3.0.9

Priority & Common Issues

  • Priority: Slow page load performance in some instances.
  • Post Meta description & images are gone (IREF 19328)
  • Buttons no showing on mobile
  • Remove LinkedIn and Google Plus API calls.
  • Pinterest fallback image does not work. (IREF 19353)
  • Update checker sporadically not working.

Fringe & Extemely Rare (Compared to other issues).

  • Share counts not always displaying or updating (IREF 19338, 19308)
  • CSS not being sent to client? This is a very fringe case. We've only had this reported one time and it appears that it is simply something blocking our plugin from enqueing the CSS.
  • Inconsistent display of Total Shares button. This is quite likely a caching issue of some sort. (IREF 19268)
  • This issue has solved itself in multiple cases after a few days. People write in describing the issue, then a few days later, say they are showing fine. Example: IREF 18167

Affiliate WP
AffiliateWP registration still not available

  • Update the version number to 1.1 for a new release.
  • Set all conditionals to check for core version 3.0.0+
  • Ensure that the registration and update checker is hooked into the current framework (I think this step is already done.)
  • Once reviewed, we'll update it in the udpates folder and iterate the version number in EDD.

Misc

  • Admin settings not saving in the options page.
  • Specifying a page ID in the shortcode isn't working - the parameter is being ignored
  • Buffer share still showing + between the words instead of spaces
  • Bitly authentication not working for many users
  • When Bitly is turned on, some users get Notice: Undefined index: google_analtyics in /public_html/wp-content/plugins/social-warfare/functions/utilities/SWP_URL_Management.php on line 128

Solved in 3.0.8

  • In some instances, the pro settings don't display on the options page. This is fixed by clicking unregister and then reregistering it. It may also be fixed by clicking "save changes".
  • Create a changelog in the readme.txt for 3.0.8
  • if single "floating buttons" is set to OFF in the post editor the global settings overwrite it and they remain ON
  • Total shares doesn't show with shortcode/function when nothing in the buttons parameter is passed in. If nothing is passed in, it needs to display whatever is set in the global options.
  • Floating buttons are still losing their position settings - defaulting to top of the page. When left side is chosen, the size is always 140% and the position is top left instead of center left.
  • Google Plus moved out of the active state on one test site. Not an emergency but others may do the same thing. Had to clear browser cache to get all the button options to show, so that may be part of the problem.
  • Still no floating bar on mobile
  • Pretty sure this one isn't us: Console error on admin pages, likely because of the double slash in this URL: Refused to apply style from 'https://ajax.googleapis.com/ajax/libs/jqueryui//themes/smoothness/jquery-ui.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.

The following three errors likely showed up between updating core and updating pro, but putting them here just in case.

  • [Thu May 24 12:38:46.008059 2018] [proxy_fcgi:error] [pid 2442] [client 127.0.0.1:41601] AH01071: Got error 'PHP message: PHP Warning: require_once(/home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/functions/Social_Warfare_Pro.php): failed to open stream: No such file or directory in /home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/social-warfare-pro.php on line 28\nPHP message: PHP Fatal error: require_once(): Failed opening required '/home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/functions/Social_Warfare_Pro.php' (include_path='.:/usr/share/php') in /home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/
  • [Thu May 24 12:37:48.019522 2018] [proxy_fcgi:error] [pid 2401] [client 127.0.0.1:41584] AH01071: Got error 'PHP message: PHP Warning: require_once(/home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare/functions/legacy/update-checker.php): failed to open stream: No such file or directory in /home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare/social-warfare.php on line 32\nPHP message: PHP Fatal error: require_once(): Failed opening required '/home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare/functions/legacy/update-checker.php' (include_path='.:/usr/share/php') in /home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare/social-warfare.php on line 32\n', referer: http://financialadvicehelp.com
  • [Thu May 24 12:38:29.377936 2018] [proxy_fcgi:error] [pid 2424] [client 127.0.0.1:41594] AH01071: Got error 'PHP message: PHP Warning: require_once(/home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/functions/Social_Warfare_Pro.php): failed to open stream: No such file or directory in /home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/social-warfare-pro.php on line 28\nPHP message: PHP Fatal error: require_once(): Failed opening required '/home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/functions/Social_Warfare_Pro.php' (include_path='.:/usr/share/php') in /home/177574.cloudwaysapps.com/qfgzktmjrc/public_html/wp-content/plugins/social-warfare-pro/social-warfare-pro.php on line 28\n', referer: https://www.moneyboat.co.uk
  • total shares has a single button hover state
  • custom colors notice "dismiss" doesn't work

These are the issues that have been solved since we last pushed out an update. These issues need tested and approved so that we can push these out to our customers.

  • right-floating boxes & circles seem a bit far from the right edge (esp when compared to the distance that the left-floating version is from the left edge) (Under review)
  • Left/right floating buttons, on hover, with custom color or custom color outlines has transparent background and text color
  • Pro features are hidden despite being "registered" - you have to unregister and then reregister to bring them back (Under review)
  • Left/right floating style "circle" still has a flat right side before hovering over the items
  • Style Buttons preview buttons don't reflect custom colors or custom color outlines. THIS IS FEATURE REQUEST. NOT A BUG. WE HAVE NEVER HAD THIS MECHANISM.
  • Registration tab not showing other add-ons that are installed and activated. Note: This isn't a bug in 3.0. The addons need updated to use the new registration framework, and have already been updated to do so internally. Once we get 3.0 stable, we will immediately then release the new version of AffiliateWP to interact with the new framework.
  • left floating buttons are set to show on bottom on mobile, but there are no buttons on mobile. same for top on mobile. i tried setting a number of buttons to see if that mattered and it didn’t
  • When floating buttons have been set to left side and you change to bottom/top, you end up with two sets - one on the left and one on bottom/top. May need to set the static buttons to show to see this.
  • The left side floating buttons switch to their hover state when hovering anywhere on the left side of the screen, even when nowhere close to the buttons.
  • Archives/categories are OFF for static but buttons showing under posts and on a CPT archive
  • CTT is missing the Twitter icon on the front end - also the first two styles appear to be different than they were previously but not sure if that's urgent right now. NOTE: This is most likely some CSS selectors that may need to be updated. If so, this is potentially, a quick, easy fix.
  • Global floating OFF for pages, ON for an individual page - no buttons
  • Fade-in effect, when triggered, flashes on then off then on again. Fade-in effect also leaves buttons visible on initial page load instead of initially hidden as they should be. (This has been moved to a 3.1.0 improvement to be made for that release.)
  • (3.1.0) iref 18566 - Pinterest image hover popup shows a broken image that can't be saved. The popup shows a 404 for the image because it's looking for (post-url)/wp-content/uploads/blahblahblah.jpg instead of (domain)/wp-content/uploads/blahblahblah.jpg (Moving this to it's own issue and tagging it for version 3.1)
  • PHP function still not working (shortcode also reported not working for a LOT of customers). Adding the following: if (function_exists('social_warfare')): social_warfare(); echo 'FUNCTION EXISTS'; var_dump(social_warfare()); endif; provides this result on 3.0.7: FUNCTION EXISTS NULL. Bother of those are valid. The function is saying that is does exist, and when var_dumped it is null because the function does NOT return anything to be dumped, it echoes the html directly to the screen.
  • [19-May-2018 10:37:19 UTC] WordPress database error Deadlock found when trying to get lock; try restarting transaction for query DELETE FROM janam__postmeta WHERE meta_id IN( 4192637 ) made by do_action('wp_ajax_nopriv_swp_cache_trigger'), WP_Hook->do_action, WP_Hook->apply_filters, swp_cache_rebuild, swp_cache_reset_timestamp, delete_post_meta, delete_metadata Note: This appears to happen when two functions are attempting to update a field in the DB at the same time. This could spawn from the migrator running on every page load. Since we have it now set to ONLY ever run one single time, this should solve this issue fully.
  • Several reports that commenting out new SWP_Database_Migration();
    on line 153 of functions/Social_Warfare.php fixes both database issues and slow load times, as well as some compatibility issues with other plugins that use metaboxes
  • Many users reporting a new JS error in the editor screen referring to s("#social_warfare .sw-premium-blocker").tooltip({items:"#social_warfare .sw-premium-blocker", in admin.min.js "s(...)tooltip is not a function" - login to see it at iref 18633. NOTE: We no longer use premium-blocker elements so this is most likely legacy JS that should simply be removed.
  • Global setting for floating buttons ON for pages does not display the floating buttons
  • Some sites are getting this error in the Pinterest popup for the image pin hover: Parameter 'image_url' with the value 'https:data:image/gif' is not a valid URL format
  • Fatal error: Uncaught Error: Call to undefined function wp_get_current_user() in /www/wp-includes/capabilities.php:590 Stack trace: #0 /www/wp-content/plugins/simply-exclude/simplyexclude.php(2055): current_user_can('manage_options') #1 /www/wp-includes/class-wp-hook.php(286): SimplyExclude->se_filters(Object(WP_Query)) #2 /www/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters('', Array) #3 /www/wp-includes/plugin.php(515): WP_Hook->do_action(Array) #4 /www/wp-includes/class-wp-query.php(1634): do_action_ref_array('pre_get_posts', Array) #5 /www/wp-includes/class-wp-query.php(3230): WP_Query->get_posts() #6 /www/wp-includes/post.php(1704): WP_Query->query(Array) #7 /www/wp-content/plugins/social-warfare/functions/utilities/SWP_Database_Migration.php(106): get_posts(Array) #8 /www/wp-content/plugins/social-warfare/functions/utilities/SWP_Database_Migration.php(40): SWP_Database_Migration->post_meta_is_migrated() #9 /www/wp-content/plugins/social-warfare/functions/Social_Warfare.php(153): SWP_Database_Migration->__ in /www/wp-includes/capabilities.php on line 590
  • Yummly button is completely missing (verified on my own sites)
  • right-floating boxes & circles seem a bit far from the right edge (esp when compared to the distance that the left-floating version is from the left edge)
  • Yummly categories/tags still don't work in the Display settings
  • StumbleUpon button is completely missing when core is installed by itself
  • StumbleUpon links are still being shortened via Bitly and apparently this keeps the counts from updating as SU counts Bitly URLs as separate links
  • Notice: Undefined index: google_analtyics in /home/castlevi/public_html/wp-content/plugins/social-warfare/functions/utilities/SWP_URL_Management.php on line 128
  • Deprecated: Non-static method SWP_CURL::file_get_contents_curl() should not be called statically in /home/castlevi/public_html/wp-content/plugins/social-warfare/functions/utilities/SWP_URL_Management.php on line 320
  • the total buttons parameter is the only form recognized. we should probably add Total and Totals just to make it fool-proof (a.k.a. Dustin-proof)
  • A few settings are being overwritten on update: float size, float position, float alignment, float mobile.
  • previous style settings were lost
  • unless set again and "save changes", floating styles remain broken
  • Total count container for right/left floating circles cuts off text for larger share counts
  • Circles left/right floating shape, on initial load, has the left side of the circles cut off until you over over the area (they then become completely rounded)

Misc and/or Somewhat Isolated Events

  • Admin column social share counts don't match front end. Sorting by shares makes most pages disappear from the list. (This is super minor. We'll patch this up next week.) This should now hopefully be fixed with the changes to the share count fields.
  • Conflict with MailPoet - iref 17561
  • Plugin is sending hundreds of requests to Facebook - one customer reported 466 in 5 minutes.

Shipped in 3.0.7

  • image hover pin button isn't appearing anywhere regardless of settings

  • Click to Tweet isn't working (Could not replicate, need more info.)

  • Total is displayed even if you are only calling specific buttons. For example, [social_warfare buttons="WhatsApp"] displays WhatsApp + Totals.

  • side-floating buttons, on hover, don't display share text (flat/fresh)

  • buttons do not accept custom styling when "Inherit Visual Options" is set to NO

  • Catchable fatal error: Object of class SWP_Google_Plus could not be converted to string in /home/cpjca/public_html/dev_cpj/wp-content/plugins/social-warfare/functions/options/SWP_Option_Icons.php on line 84

  • settings page nav bar does not extend 100% width of screen (I'm not able to replicate this at all.)

  • Share counts don't seem to be updating. We need to trace this through the line of progression. First, is the AJAX trigger being triggered and output. Secdond, are the requests being sent to admin AJAX to rebuild the share count caches. Third, are the cURL function and DB function working to fetch and store the share counts.

  • there is a weird h2 in our popular posts widget that appears above the actual h4 for the title. Screenshot of the HTML: https://cloudup.com/caXNyvPRa6J Weirdly, it shows up the same way on my site but as h3 instead of h2.

  • Page settings are overriding homepage when the homepage is a static page

  • Bitly authentication leads to a blank screen and never actually authenticates.

  • When no buttons are active, this notice shows: Notice: Undefined variable: api_responses in /social-warfare/functions/utilities/share-count-function.php on line 111 Wrap pretty much the entire function in a conditonal that checks if the global networks array is empty. Add date/version to doclblock to log the change.

  • Notice: Undefined index: button_alignment in /public_html/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Buttons_Panel.php on line 371

  • 2.3.5 Upgrade Glitch - Create a legacy version of the upgrade class so that the upgrader in the old version will still have access to it.

  • Bottom floating buttons disappear on mobile - confirmed on my sites
    Sharing buttons/function

  • via @[username] not being added to pin descriptions

  • email share button is putting short URL in subject line and nothing in body of email

  • side-floating buttons icons are aligning left when they should be centered (flat/fresh)

  • when displayed at 140%, buttons still partially show on right-float and left-float when they should be hidden

  • even though no custom color option is selected, custom color inputs still show

Shortcodes

  • They're echoing instead of returning in some instances causing them to appear at the very top of the content instead of where they are positioned in the editor.
  • Left floating buttons persist when turned off in global position settings. Also happens if they are set to float on the right side but turned off - they appear on the left.
  • Excerpts return "No content" when SW is active, even if the buttons aren't turned on for archives.
  • Min height/width are showing for image hover pin button when it's toggled off

DB Migration Issues
The fixes are under review.

Buttons Scale
The fixes are under review.

Buttons Display

  • Floating buttons acting wonky on some installs (NEED MORE INFO)

They don't display where they should, they display where they shouldn't.... Random total shares floating on left side of many homepages when floating buttons are turned off globally.... I don't know how much more info I can provide - thought this was obvious.

  • Buttons no longer display on excerpts regardless of settings

Shortcode Related Issues

  • Double content showing on some posts/pages - potentially related to the shortcode

  • Shortcode pulls in the description and outputs it within the content instead of showing share buttons on some sites THE SOCIAL MEDIA DESCRIPTION

Misc.

  • Buffer button doesn't include the article title (We've never had the title in there. This is a feature request, not a bug.) Tweeting an article via Buffer most certainly does include the title. This is not a feature request.
  • Current Domain recovery setting doesn't work - recovered shares aren't showing because of it. Make sure that the function that returns the alternate permalink format is returning it properly according tot he permalink settings in the options page. If so, that will fix this.
  • When current and former domain are filled out in share recovery settings, the former domain field resets to match the current domain field on save.

Error Codes
It is better for a feature to gracefully not work than for it to throw an error for users. So in this case, wrape the foreach in a conditional checking for is_array() or something like that whilst also trying to figure out what the actual cause might be and actually solving that as well. 1. Make it not throw an error. 2. Fix the cause if possible.

  • Warning: Invalid argument supplied for foreach() in /srv/users/serverpilot/apps/degraprojects-frans/public/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 46

  • Buttons missing on mobile

  • Recoverable fatal error: Object of class SWP_Google_Plus could not be converted to string in /wp-content/plugins/social-warfare/functions/options/SWP_Option_Icons.php on line 74

  • Warning: Illegal offset type in isset or empty in /wp-content/plugins/social-warfare/functions/options/SWP_Option_Icons.php on line 44

  • Warning: Invalid argument supplied for foreach() in /wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 108

    • This is resolved with the same solution that fixes 'Invalid argument supplied for foreach' on line 46 of share-count-function.php.
  • Social Media description not migrating.

  • Custom tweet field not migrating

  • Button sizes over 100% don't stay in their container (Revert these to the attributes and JS we used before.)

  • Popular Posts widget doesn't update

  • Customer reports "as long as I have a number in the 'number of buttons' field, I got that many floating buttons EVEN IF I had floating buttons turned off."

  • Shortcode prevents content from displaying in some cases

    • Commits 84d44f5372f43aae5f6ee654f0a009a281872756 and a5cc1b84cadc47bd274c5b246fb9fde86682def6
  • Some customers have no Publish button inside the post editor when 3.0.4 is active

  • Two toggles for Tweet Count toggle.

  • Total share count won't turn off - random total counts showing up on homepages

  • Notice: Undefined index: og_tags in /home/ketovale/public_html/wp-content/plugins/social-warfare-pro/functions/frontend-output/SWP_Pro_Header_Output.php on line 87 and Notice: Undefined index: og_tags in /home/ketovale/public_html/wp-content/plugins/social-warfare-pro/functions/frontend-output/SWP_Pro_Header_Output.php on line 270 when using the migrate post meta parameter

  • Adding tags in the post editor doesn't work when 3.0.4 is active

  • Bitly links replaced themselves and generated new URLs

  • Warning: arsort() expects parameter 1 to be array, boolean given in /home/marqueso/public_html/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Buttons_Panel.php on line 524

  • UTM URLs are scrambled

  • Warning: Invalid argument supplied for foreach() in /home/marqueso/public_html/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Buttons_Panel.php on line 525

  • Pinterest hover doesn't work on 3.0.4

  • Notice: Undefined index: button_alignment in /home/amyjanec/public_html/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Buttons_Panel.php on line 342

  • Notice: Undefined index: float_mobile in /home/amyjanec/public_html/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Buttons_Panel.php on line 404

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

  • [10-May-2017 14:13:54] PHP Warning: DOMDocument::loadHTML() [domdocument.loadhtml]: Empty string supplied as input in /home/sooverth/public_html/wp-content/plugins/social-warfare/functions/utilities/utility.php on line 123
@eheuer

This comment has been minimized.

Copy link

commented May 9, 2018

When I update from 2.3.5 to 3.0.0 I am getting an "HTTP ERROR 500". That probably isn't super helpful, but I wanted to share my findings. I have since reverted back to version 2.3.5.

2018-05-09_1136

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@eheuer Yes. We're tracking this issue and are working on a fix right now. It should be resolved within a matter of minutes from now.

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@eheuer We just published 3.0.1 to the WordPress repo and it should fix this issue immediately for you. Somehow there was a glitch in the file transfer process and a few files didn't make it into the published version. We've added those files back in and everything seems to be working now.

@nutsandbolts

This comment has been minimized.

Copy link

commented May 9, 2018

Floating buttons are weirdly showing up at the bottom of archive pages, just for a split second, on this site. You don't see it until you reach the bottom set of buttons - this is in Chrome: https://domainnamewire.com/

@eheuer

This comment has been minimized.

Copy link

commented May 9, 2018

First issue I see with 3.0.1 is under "Position Share Buttons" I am missing custom post types.
2018-05-09_1230

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@eheuer We're digging into this right now. We'll see if we can't come up with a solution in the next few minutes for you on this. :-)

@eheuer

This comment has been minimized.

Copy link

commented May 9, 2018

The second issue I am seeing is some of my pages aren't displaying the "total share counts" properly. I did see it on a couple pages but the majority of pages aren't showing it at all.
2018-05-09_1234

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@nutsandbolts I just fixed that floating issue that you reported.

@eheuer We're just finishing up on the post types bug that you reported.

Can you link me to those two pages as I think this may be a CSS issue and I'd love to look into making sure that we get it fixed as well for you.

@eheuer

This comment has been minimized.

Copy link

commented May 9, 2018

Here is the page: https://bluestemamphitheater.org/event/2018-oar-moorhead/

I am currently on the 3.0.1 version. If you want me to swap it back to 2.3.5 I can do that. Just let me know.

@nutsandbolts

This comment has been minimized.

Copy link

commented May 9, 2018

Lots of customers with debugging turned on are getting warnings:

Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_facebook_request_link' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 75 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_whatsapp_request_link' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 75 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_email_request_link' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 75 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_linkedin_request_link' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 75 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_twitter_request_link' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 75 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_format_facebook_response' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 111 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_format_whatsapp_response' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 111 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_format_email_response' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 111 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_format_linkedin_response' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 111 Warning: call_user_func() expects parameter 1 to be a valid callback, function 'swp_format_twitter_response' not found or invalid function name in /usr/www/users/haroux/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 111

@nutsandbolts

This comment has been minimized.

Copy link

commented May 9, 2018

More new ones for your reading pleasure:

[09-May-2018 18:14:11 UTC] PHP Notice: Undefined index: tweet_count_source in /www/oceanwp_118/public/wp-content/plugins/social-warfare/functions/social-networks/SWP_Twitter.php on line 63 [09-May-2018 18:14:11 UTC] PHP Notice: Undefined index: googlePlus in /www/oceanwp_118/public/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 106 [09-May-2018 18:14:11 UTC] PHP Fatal error: Uncaught Error: Call to a member function parse_api_response() on null in /www/oceanwp_118/public/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php:106 Stack trace: #0 /www/oceanwp_118/public/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Buttons_Panel.php(96): get_social_warfare_shares(5554) #1 /www/oceanwp_118/public/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Display.php(76): SWP_Buttons_Panel->__construct(Array) #2 /www/oceanwp_118/public/wp-includes/class-wp-hook.php(286): SWP_Display->social_warfare_wrapper('\t\t<div class="e...') #3 /www/oceanwp_118/public/wp-includes/plugin.php(203): WP_Hook->apply_filters('\t\t<div class="e...', Array) #4 /www/oceanwp_118/public/wp-includes/post-template.php(240): apply_filters('the_content', '<h1>\n\t\t\t\t\t\t\tCre...') #5 /www/oceanwp_118/public/wp-content/themes/oceanwp/partials/page/article.php(15): the_content() #6 /www/oceanwp_118/public/wp-includes/template.php(690): require('/www/oceanwp_11... in /www/oceanwp_118/public/wp-content/plugins/social-warfare/functions/utilities/share-count-function.php on line 106

@ckmahoney

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2018

@eheuer Do you have a minimum number of shares set? If so, total shares only displays if that minimum number has been reached.

@ckmahoney

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2018

@eheuer the above, and:

Fixes for the above so far can be downloaded with this patch.
social-warfare.zip
@nutsandbolts

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

I believe all of these items have now been fully patched.

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

018/05/09 19:42:14 [error] 1463#1463: *1407 FastCGI sent in stderr: "PHP message: PHP Warning: A non-numeric value encountered in /var/www/updownleftdie.com/htdocs/wp-content/plugins/social-warfare/functions/options/SWP_Section_HTML.php on line 371
PHP message: PHP Stack trace:
PHP message: PHP 1. {main}() /var/www/updownleftdie.com/htdocs/index.php:0
PHP message: PHP 2. require() /var/www/updownleftdie.com/htdocs/index.php:17
PHP message: PHP 3. require_once() /var/www/updownleftdie.com/htdocs/wp-blog-header.php:13
PHP message: PHP 4. require_once() /var/www/updownleftdie.com/htdocs/wp-load.php:37
PHP message: PHP 5. require_once() /var/www/updownleftdie.com/htdocs/wp-config.php:80
PHP message: PHP 6. do_action() /var/www/updownleftdie.com/htdocs/wp-settings.php:471
PHP message: PHP 7. WP_Hook->do_action() /var/www/updownleftdie.com/htdocs/wp-includes/plugin.php:453
PHP message: PHP 8. WP_Hook->apply_filters() /var/www/updownleftdie.com/htdocs/wp-includes/class-wp-hook.php:310
PHP message: PHP 9. SWP_Options_Page->load_deferred_options() /var/www/updownleftdie.com/htdocs/wp-includes/class-wp-hook.php:286
PHP message: PHP 10. SWP_Section_HTML->do_button_position_table() /var/www/updownleftdie.com/htdocs/wp-content/plugins/social-warfare/functions/options/SWP_Options_Page.php:105
PHP message: PHP Warning: A non-numeric value encountered in /var/www/updownleftdie.com/htdocs/wp-content/plugins/social-warfare/functions/options/SWP_Section_HTML.php on line 371
PHP message: PHP Stack trace:
PHP message: PHP 1. {main}() /var/www/updownleftdie.com/htdocs/index.php:0
PHP message: PHP 2. require() /var/www/updownleftdie.com/htdocs/index.php:17
PHP message: PHP 3. require_once() /var/www/updownleftdie.com/htdocs/wp-blog-header.php:13
PHP message: PHP 4. require_once() /var/www/updownleftdie.com/htdocs/wp-load.php:37
PHP message: PHP 5. require_once() /var/www/updownleftdie.com/htdocs/wp-config.php:80
PHP message: PHP 6. do_action() /var/www/updownleftdie.com/htdocs/wp-settings.php:471

@ProductivePhysician

This comment has been minimized.

Copy link

commented May 9, 2018

Hi,
Sorry to burst your bubble but I just updated to 3.0.3 and still get a fatal error...

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@ProductivePhysician Can you tell me what the fatal error is? If so, I'll fix it up right away for you!

@ProductivePhysician

This comment has been minimized.

Copy link

commented May 9, 2018

Sorry, it's not a fatal error, but an error nonetheless:

Warning: A non-numeric value encountered in /home/product3/public_html/wp-content/plugins/social-warfare/functions/options/SWP_Section_HTML.php on line 372

@Nicholas-Cardot Nicholas-Cardot changed the title 3.0.1 Immediate Bug Fix Reports 3.0.3 Immediate Bug Fix Reports May 9, 2018

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@ProductivePhysician I literally just fixed that like a minute ago. You can download it from here:

social-warfare.zip

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

If you download that, you can let me know if that fixes it. If so, we'll include that fix in the next release (soon).

@ProductivePhysician

This comment has been minimized.

Copy link

commented May 9, 2018

You're very quick :-) 👍

The error is no longer there, but the share buttons are borked now:

screenshot 1

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@ProductivePhysician For that, you'll need to reset your caching plugins. We rebuilt a lot of the html and if you don't get the new CSS and JS, it will do that. So you need the new version of the CSS to come through.

@ProductivePhysician

This comment has been minimized.

Copy link

commented May 9, 2018

Man, you're all over it.
Sorry if it was written somewhere else and I should have read more widely.
Thanks for the responsiveness! 👍 💯

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2018

@ProductivePhysician No worries. I'm the one who is sorry. Thanks so much for your patience. We'll be pushing out another update shortly to include this fix for anyone else who might be affected by that same error. Thanks so much for reporting it and giving me the chance to fix it up.

@sweethoneycode

This comment has been minimized.

Copy link

commented May 11, 2018

@nutsandbolts Nice, I was following the issue flow and didn't know the progress. Hope this helps! :)

ckmahoney added a commit that referenced this issue May 11, 2018

@DustinWStout

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2018

Settings > Style

  • preview does not show custom color or custom color outlines
  • settings page nav bar does not extend 100% width of screen

Side-floating

  • side-floating buttons icons are aligning left when they should be centered (flat/fresh)
  • side-floating buttons, on hover, don't display share text (flat/fresh)
  • even though no custom color option is selected, custom color inputs still show
  • when displayed at 140%, buttons still partially show on right-float and left-float when they should be hidden
  • Fade-in effect, when triggered, flashes on then off then on again
  • fade-in effect also leaves buttons visible on initial page load instead of initially hidden as they should be
  • buttons do not accept custom styling when "Inherit Visual Options" is set to ON

Add-ons

  • AffiliateWP add-on doesn't show in the Settings > registration tab
@DustinWStout

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2018

Sharing buttons/function

  • via @[username] not being added to pin descriptions
  • email share button is putting short URL in subject line and nothing in body of email

@Nicholas-Cardot Nicholas-Cardot changed the title 3.0.4 Immediate Bug Fix Reports 3.0.x Immediate Bug Fix Reports May 11, 2018

@Webtica

This comment has been minimized.

Copy link

commented May 12, 2018

Hi,

I am still having issues after updating to 3.0.5.

I don't have any fatal errors or php warnings and every custom post shows up in the backend but i placed the manual PHP code in my template file and that is still not showing up.
As it did before on 2.3.5 it did show up.

<?php if(function_exists('social_warfare')):
    social_warfare();
    endif;?>

it does not show any css either.
Thanks!

@vl123

This comment has been minimized.

Copy link

commented May 14, 2018

Social Warfare 3.0.5

SWP_Database_Migration generates a lot of unnecessary queries on every page load (update_hidden_post_meta, update_post_meta, etc.). On site with ~30k unique users per day it adds 10-15 seconds to fully load page and leads to db errors (lock wait timeout exceeded). I think it would be better to use option to keep migration status (especially since you already have get_last_migrated method) than execute a lot of db queries on every page request.

@prkirby

This comment has been minimized.

Copy link

commented May 14, 2018

Posts written after update do not show share counts

Not sure if this was already addressed, but I didn't see anything. My client is on 3.0.5, yet any of the articles that were published after the update are not showing any sort of share count at all. See below pictures.

Maybe an issue with share count tracking? Not sure. Let me know if there is anything I can help with!

Published May 9th

screen shot 2018-05-14 at 10 40 01 am

Published Today

screen shot 2018-05-14 at 10 40 17 am

@nutsandbolts

This comment has been minimized.

Copy link

commented May 14, 2018

@prkirby Link to the site, please?

@prkirby

This comment has been minimized.

Copy link

commented May 14, 2018

@paulyabsley

This comment has been minimized.

Copy link

commented May 15, 2018

Having the same issue as @Webtica (#535 (comment)).

Social buttons placed with php function (social_warfare();) not displaying. No errors and nothing in the console.

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 15, 2018

@paulyabsley This has been fixed and will be included in our 3.0.6 release later today. :-)

@DustinWStout

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2018

Findings in 3.0.6:

Styling

  • previous style settings were lost
  • unless set again and "save changes", floating styles remain broken
  • right-floating boxes & circles seem a bit far from the right edge (esp when compared to the distance that the left-floating version is from the left edge)
  • Total count container for right/left floating circles cuts off text for larger share counts

cut-off-share-counts

  • Circles left/right floating shape, on initial load, has the left side of the circles cut off until you over over the area (they then become completely rounded)

flat-edges-on-circles

Shortcode

  • the total buttons parameter is the only form recognized. we should probably add Total and Totals just to make it fool-proof (a.k.a. Dustin-proof)
@Webtica

This comment has been minimized.

Copy link

commented May 16, 2018

Hi!

I am still having the same issue on 3.0.7
The bar is not showing up on front end when I have :

<?php if(function_exists('social_warfare')):
    social_warfare();
    endif;?>

Thanks,
Dieter

ckmahoney added a commit that referenced this issue May 16, 2018

Added condition for empty content. #535
In cases where a gallery may pull in posts, this check for is_singular() prevents the buttons from being printed with each post.
@vl123

This comment has been minimized.

Copy link

commented May 17, 2018

Social Warfare 3.0.7

SWP_Database_Migration: update_post_meta and update_hidden_post_meta methods are still executed on every page load. I think that's because post_meta_is_migrated always returns false and update_last_migrated doesn't update last_migrated option because it isn't executed at all.

@sarasumic

This comment has been minimized.

Copy link

commented May 18, 2018

I am still having this issue after updating to 3.0.7. On some blog posts, the counts are just not displayed (it says 0 shares in the wordpress dashboard, but they really had over 100 shares). I cleared my cache and everything.

@brevstgaard

This comment has been minimized.

Copy link

commented May 26, 2018

Installed the 3.0.8 release yesterday, got the same CSS-problem as ProductivePhysician. After switch of browser it was fine in backend but still can´t get the "Get System Status" butoon to work and don´t have drag-and-drop function related to the social icons. Tried to emty caching everythere and switch browser with no luck so far. Tried on a fresh WP install (latest) but here I got a 500 error after installing the free package so quickly stopped with that idea.

Now on mobile I can´t find a fix for this:

screenshot_chrome_android_pixel2_socialwarfare_error

Live example can be seen on: https://whiskygentle.men/whisky-afkrydsnings-notat-ark/

@Nicholas-Cardot

This comment has been minimized.

Copy link
Collaborator Author

commented May 26, 2018

@brevstgaard When I visited that page, they look exactly as they are supposed to. This is because I have never visited there before so I got the latest, newest versions of the CSS and JS delivered to my browser from your website. This means 100% that this is a caching issue. You have old CSS and JS in your browser that isn't downloading and using the latest version. Please clear all your browser caches and this issue should go away immediately.

@GJMichael

This comment has been minimized.

Copy link

commented May 28, 2018

Hi,

This morning we updated the plugin to v3.0.8, Now we are seeing the following soft error in our logs:

Undefined index: click_tracking
/[webroot]/wp-content/plugins/social-warfare/functions/frontend-output/SWP_Script.php
Line 170

Started happening after updating to v3.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.