Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`six` library is still vendored in 0.14 wheel release #159

Closed
spulec opened this issue Nov 6, 2019 · 5 comments
Assignees
Labels

Comments

@spulec
Copy link

@spulec spulec commented Nov 6, 2019

For the most recent release (0.14), I am getting an error after installing the wheel.

>>> import ecdsa
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/steve/.virtualenvs/pyqs2/lib/python2.7/site-packages/ecdsa/__init__.py", line 1, in <module>
    from .keys import SigningKey, VerifyingKey, BadSignatureError, BadDigestError,\
  File "/Users/steve/.virtualenvs/pyqs2/lib/python2.7/site-packages/ecdsa/keys.py", line 72, in <module>
    from . import ecdsa
  File "/Users/steve/.virtualenvs/pyqs2/lib/python2.7/site-packages/ecdsa/ecdsa.py", line 57, in <module>
    from . import ellipticcurve
  File "/Users/steve/.virtualenvs/pyqs2/lib/python2.7/site-packages/ecdsa/ellipticcurve.py", line 37, in <module>
    from six import python_2_unicode_compatible
ImportError: cannot import name python_2_unicode_compatible

If I install using without using the wheel (pip install ecdsa==0.14 --no-binary :all:), I can confirm this doesn't happen. When looking at the files that get installed, I can see that six.py is still bundled for the wheel, but not the source installation.

All of this was on Python 2.7.12. Let me know if I can provide any more information to help debug.

@tomato42

This comment has been minimized.

Copy link
Collaborator

@tomato42 tomato42 commented Nov 6, 2019

yes, I indeed see six.py in ecdsa-0.14-py2.py3-none-any.whl, will need to fix it

on python3 it imports the system six so I didn't notice it when checking... sigh

@spulec

This comment has been minimized.

Copy link
Author

@spulec spulec commented Nov 6, 2019

Someday we will all live in a Python3 world and leave problems like this behind :)

@tomato42

This comment has been minimized.

Copy link
Collaborator

@tomato42 tomato42 commented Nov 6, 2019

RHEL 7 is going to be supported till like 2027... I won't hold my breath for this particular "someday" 😄

@tomato42 tomato42 added the maintenance label Nov 6, 2019
@tomato42 tomato42 self-assigned this Nov 6, 2019
@tomato42

This comment has been minimized.

Copy link
Collaborator

@tomato42 tomato42 commented Nov 6, 2019

@spulec

This comment has been minimized.

Copy link
Author

@spulec spulec commented Nov 6, 2019

Thanks for the quick fix! I can confirm it works.

Thanks for all of your work on this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.