[WIP] Don't expose the value of a model's attribute in assertions#7370
Merged
igorT merged 3 commits intowarp-drive-data:masterfrom Nov 30, 2020
Merged
[WIP] Don't expose the value of a model's attribute in assertions#7370igorT merged 3 commits intowarp-drive-data:masterfrom
igorT merged 3 commits intowarp-drive-data:masterfrom
Conversation
snewcomer
reviewed
Nov 20, 2020
Contributor
snewcomer
left a comment
snewcomer
left a comment
There was a problem hiding this comment.
This looks great! A test fix and this should be g2g. Thanks for this PR.
Contributor
|
👍 |
… because we want to explicitly test DEBUG vs NOT DEBUG, and assertions are stripped in prod
Contributor
Author
|
Thanks to @igorT for helping on discord |
snewcomer
reviewed
Nov 24, 2020
| set(record, 'isArchived', true); | ||
| }, | ||
| /Attempted to set 'isArchived' on the deleted record <person:1>/, | ||
| "Assertion does not leak the 'value'" |
Contributor
There was a problem hiding this comment.
Not sure how strict we are with dbl vs single quotes.
igorT
pushed a commit
that referenced
this pull request
Dec 1, 2020
* don't expose the value of a model's attribute in production builds
igorT
pushed a commit
that referenced
this pull request
Dec 1, 2020
* don't expose the value of a model's attribute in production builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at fixing: #7270
Unresolved questions
Is
DEBUGthe correct flag to use?(I noticed other users have a similar question: What determines the value of DEBUG? glimmerjs/glimmer-env#3)
What commit [TAG] prefix should I use? It doesn't seem to fit into anything as per CONTRIBUTING.md instructions