Skip to content

chore: update v4-main infra and tooling to match main branch#9598

Merged
runspired merged 117 commits intov4-mainfrom
v4-infra
Dec 19, 2024
Merged

chore: update v4-main infra and tooling to match main branch#9598
runspired merged 117 commits intov4-mainfrom
v4-infra

Conversation

@runspired
Copy link
Copy Markdown
Contributor

No description provided.

@runspired runspired self-assigned this Nov 12, 2024
@lfloyd117
Copy link
Copy Markdown

Any movement on this? This bug seems to be blocking us from getting to LTS of ember-data 4 so we can be prepared to move to 5

@runspired
Copy link
Copy Markdown
Contributor Author

@lfloyd117 what issue?

@lfloyd117
Copy link
Copy Markdown

@runspired
This: #8791
One of our devs said he talked to you and found there was this bug in ember-data 4.12 that blocked us and you were making this PR for an ember-data 4.13 that would fix the issue, that PR being this

@runspired
Copy link
Copy Markdown
Contributor Author

@lfloyd117 not familiar with a discussion with anyone on that specific ticket: that said, the idea of 4.13 is that it contains all fixes and additions from V5 (while attempting to preserve deprecated things present in V4). I notice that particular fix never got backported (probably no one ever asked for it to be, would have been an easy one to), but yes it will be fixed in 4.13 too.

@lfloyd117
Copy link
Copy Markdown

@runspired I can ask them to check on this thread later (they are on a different timezone and not on currently).
Is there any ETA on fixes for issues like that being backported to 4 via 4.13?

@softcPana
Copy link
Copy Markdown

Hello @runspired We talked about this on the discord server 2 weeks ago in this thread.

runspired and others added 9 commits December 16, 2024 23:28
* Fix tsconfig.json for the vite app

* Remove @embroider/macros from the overrides list in the root package.json

* Upgrade to latest ember-qunit
@runspired runspired merged commit 5704c6f into v4-main Dec 19, 2024
@runspired runspired deleted the v4-infra branch December 19, 2024 00:06
@softcPana
Copy link
Copy Markdown

@runspired when will this be merged into lts-4-12?

@runspired
Copy link
Copy Markdown
Contributor Author

@softcPana it won't be! v4-main is a new release branch and will become 4.13. We're about 90% of the way to being able to release 4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants