Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt much slower in Fish in Warp #883

Closed
ctbeiser opened this issue Apr 5, 2022 · 5 comments
Closed

Prompt much slower in Fish in Warp #883

ctbeiser opened this issue Apr 5, 2022 · 5 comments

Comments

@ctbeiser
Copy link

ctbeiser commented Apr 5, 2022

Discord username (optional)

No response

Describe the bug

If I open a bash shell in Warp, it's about as fast as in Terminal.

However, if I use Fish, things get much slower. For example, pressing return in a small directory with a git repo takes 0.2s in Warp, but is ~instant in Terminal or with Bash.

If I go somewhere without a git repo, it takes 0.02s—much better.

My guess is that there's a holdup that affects my prompt, which gets git info from the local directory.

To Reproduce

  • Install fish
  • Set prompt to "compact git"
  • enter a git repo
  • press return

Expected behaviour

prompt shows ~instantly

Screenshots

Screen Shot 2022-04-05 at 12 41 35

Operating System

MacOS

OS Version

12.3

Additional context

fish version 3.3.1
@warpdotdev-dx
Copy link
Member

warpdotdev-dx commented Apr 12, 2022

@ctbeiser
Copy link
Author

ctbeiser commented Apr 12, 2022

Here's what I've found:

If I run fish_config prompt choose informative_vcs, and I'm in a git repo, then I get the slowdown.

Meanwhile, fish_config prompt choose informative is perfectly fast.

Other than that, my fish install is basically out of the box, so I would expect that should be enough to reproduce.

@warpdotdev-dx
Copy link
Member

warpdotdev-dx commented Apr 13, 2022

@elviskahoro
Copy link
Member

elviskahoro commented Apr 17, 2022

One of our engineers looked into this and we believe the slowdown is due to fish querying the Git status, which will naturally take longer than not doing so. However we actually don't think the slow down is anything we're doing—nor does it seem like it's significantly slower in Terminal.app or iTerm.

It probably looks much worse in Warp though cause of this bug:

@ctbeiser
Copy link
Author

ctbeiser commented Apr 17, 2022

Looking more closely, I think you may be right—the thing I'm noticing is that "time until I can read the output of the command" is much higher, because I can't until it stops moving. Happy to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants